Giter VIP home page Giter VIP logo

Comments (3)

sbatson5 avatar sbatson5 commented on July 1, 2024

Hi @nosisky

You're right, our where method doesn't actually do any querying against the mock database you create. This was on purpose as rebuilding all the of potential logic firestore has could make this library really hard to maintain and we questioned what the value in reproducing that logic is.

Our thought process was "if the where clause actually filters the filters the mock data and you assert that the right data is returned, then all you've done is tested our code." However, I do understand your point that you have cases where you need to assert that a where returns no results and we should allow a way to test for that.

I don't want to go down the rabbit hole of completely rebuilding everything that where (and other methods) can do. But we should think of a way to test this case 🤔

I am open to suggestions!

from firestore-jest-mock.

jdziek avatar jdziek commented on July 1, 2024

Hi @nosisky
I'm facing similar issue and was wondering if you found a work around?
I tried mocking firestore per each test but due to that I ran into other problems

from firestore-jest-mock.

sbatson5 avatar sbatson5 commented on July 1, 2024

@nosisky & @Foxford13 We added a new optional flag you can pass to mockFirebase in your tests that should allow where to actually return the results of your query:

https://github.com/Upstatement/firestore-jest-mock#simulatequeryfilters

from firestore-jest-mock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.