Allow sending metadata about scalapb-grpcweb HOT 4 CLOSED

I have squashed PR #20 and made some additional changes that were committed in 52f7fd4:

• Code gen and core library moved to com.thesamet.scalapb.grpcweb
• The generated code is inside an object name suffixed by GrpcWeb, i.e. MyServiceGrpcWeb:
• The methods that take metadata and those that don't are generated inside a single trait. I preferred this over default parameters due to the having a default value for a metadata between two required args (request and responseObserver) is odd.
• the new generator needs to run in addition to the existing generator (not to invoke it) for better modularity. If all generators did that, they couldn't be combined to a single run since they all would generate Scala code for message types.

Please check out the latest snapshot and provide feedback if we can close this issue.

Snapshots: https://oss.sonatype.org/content/repositories/snapshots/com/thesamet/scalapb/grpcweb/
Example updated: https://github.com/scalapb/scalapb-grpcweb/tree/master/example

from scalapb-grpcweb.

From my tests, it looks good to me, I have submitted a small PR to update minor details

We'll try integrating this internally on a project and get back to you in the next week.

Thanks!

from scalapb-grpcweb.

I believe this can be closed.

from scalapb-grpcweb.

I confirm we have been using this successfully for months now.

Thanks!

from scalapb-grpcweb.