Expected Behavior Loaded scalar from a CDN and not using a scalar

Sure: <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Responses assumed to be from proxy about scalar HOT 7 CLOSED

scalar commented on May 13, 2024

Responses assumed to be from proxy

from scalar.

Comments (7)

danp commented on May 13, 2024 2

👍

Actually, before I open another issue, I also had to add this patch to get the JSON bodies to show:

diff --git a/packages/api-client/src/components/ApiClient/Response/Response.vue b/packages/api-client/src/components/ApiClient/Response/Response.vue
index 712a2c8d..924b8c3b 100644
--- a/packages/api-client/src/components/ApiClient/Response/Response.vue
+++ b/packages/api-client/src/components/ApiClient/Response/Response.vue
@@ -59,6 +59,9 @@ const responseData = computed(() => {
   if (value && isJsonString(value)) {
     return JSON.stringify(JSON.parse(value), null, 2)
   }
+  if (value && !isJsonString(value)) {
+    return JSON.stringify(value, null, 2)
+  }
 
   return value
 })

Perhaps related? Was getting an error in the dev console otherwise.

from scalar.

danp commented on May 13, 2024 1

Sure: #331. I included the second diff but I'm guessing it's not right. Feel free to edit/etc or I can remove it if you want.

from scalar.

danp commented on May 13, 2024

I was able to get things going (partially, will open another issue) with this:

diff --git a/packages/api-client/src/helpers/sendRequest.ts b/packages/api-client/src/helpers/sendRequest.ts
index 493c25d4..d130a04b 100644
--- a/packages/api-client/src/helpers/sendRequest.ts
+++ b/packages/api-client/src/helpers/sendRequest.ts
@@ -76,7 +76,8 @@ export async function sendRequest(
     await axios(config)
       .then((res) => {
         return {
-          ...res.data,
+          ...(proxyUrl ? res.data : res),
+          ...(!proxyUrl && {statusCode: res.status}),
           error: false,
         }
       })

from scalar.