Giter VIP home page Giter VIP logo

Comments (4)

saeltz avatar saeltz commented on July 26, 2024

I dug a little into this: For Scala 2.13.10 in the ticket mentioned above, scoverage wasn't released yet. That has been resolved with scoverage 2.0.5. That helps us a bit but brings up another issue: scoverage 2.x+ is a new major version that doesn't support Scala 2.11.x anymore. So we have three options:

  1. Drop support for Scala 2.11.x (fine for me, nothing should block users to update to Scala 2.12.x)
  2. Drop coverage from our CI (fine for me as well, as long as we demand tests for new inspections)
  3. Have some if-else in sbt to use a different scoverage version for Scala 2.11.x than for 2.12+

Irregardless, for scoverage 2.x we would need to add a library dependency scheme to ignore the conflict in scala-xml that raises an error otherwise because version 2.x+ of scala-xml is used in the newer scoverage whereas we use 1.3.0 for Scala 2.11.x. Like this:

// sbt-scoverage plugin depends on scala-xml 2.x.x which is not available for Scala 2.11.x
libraryDependencySchemes += "org.scala-lang.modules" %% "scala-xml" % "always"

Your thoughts?

from scapegoat.

saeltz avatar saeltz commented on July 26, 2024

Maybe @sksamuel has an opinion?

from scapegoat.

jozic avatar jozic commented on July 26, 2024

It seems dropping Scala 2.11 makes life easier for everyone, most likely people who stuck with 2.11 can't upgrade things much anyway
Just my 2c

from scapegoat.

sksamuel avatar sksamuel commented on July 26, 2024

from scapegoat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.