Giter VIP home page Giter VIP logo

Comments (2)

scchn avatar scchn commented on August 22, 2024

Thanks!

I have no experience reading images on other platforms, I can only add some compilation conditions for Apple platforms.

Please feel free to create a pull request if you know how to implement this feature.

from swift-zpl.

sliemeobn avatar sliemeobn commented on August 22, 2024

I see you already added conditional imports! 🙏

If you are ok with a breaking the public API a tiny bit I would suggest keeping the GraphicField type free of non-portable types, and only provide a bunch of (conditional) convenience initializers.

That way the same type can live on all platforms, but if CoreGraphics is available you can use your awesome conversion magic from CGImage.

Another benefit this potentially has is that we could have an initializer with just Data and size, and I would even offer one with the pre-encoded string that is used in ZPL instead of raw bytes.

I think the use case exists where it makes sense to just hard-code a pre-converted ZPL-string of a logo or something.

On the type itself I would simply store size and stringified data.

Let me know what you think, I am happy to provide a PR if you agree (might take a few weeks though).

from swift-zpl.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.