Giter VIP home page Giter VIP logo

Comments (3)

boydm avatar boydm commented on July 16, 2024

I see the point you are making. Good question on if it should be a change to the text primitive to pick up the default from them or a label control.

I'm leaning toward updating the primitive itself.

from scenic.

lawik avatar lawik commented on July 16, 2024

I took a brief look at it hoping I could throw a PR in here for that case. But I didn't quite follow where that piece of action would have to happen from my brief attempt.

If you could point me in the right direction I'd be happy to make a proof-of-concept we could consider.

from scenic.

boydm avatar boydm commented on July 16, 2024

This isn't so straight-forward. Text is just a primitive and thus doesn't have a natural place to add code telling to pick up the contents of a theme. Instead it just inherits whatever the current font styles are form above it in the graph tree.

Probably the best place is if a theme is set during the Graph.build(...) function, then extract and set the font styles. Assuming they are not already set explicitly by the dev.

Memory is fuzzy. May have already done this? Need to take a look.

from scenic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.