Comments (3)
Hi there,
Thank you for your report and testing.
I carefully stepped through the voice rendering code requesting various sample counts and I ended up finding a different issue where the state of the lowpass filter was not carried across multiple render calls. But that ended up only introducing some noise, never skipped a sample or outputted zero like your recording seems to contain.
Did you run example2.c as is or was your code just based on it? If you modified it, can you post code?
Also, instead of recording a playback you could dump the rendered buffers directly into a file and then inspect it with the tool Audacity with File -> Import -> Raw Data.
Something kinda like this:
enum { BUFFER_WINDOW = 333 };
float Buf[BUFFER_WINDOW * 2];
FILE* f = fopen("D:\\dev\\github\\TinySoundFont\\tsf_work\\out.raw", "wb");
tsf* TSF = tsf_load_filename("D:\\dev\\github\\TinySoundFont\\trunk\\examples\\florestan-subset.sf2");
tsf_set_output(TSF, TSF_STEREO_INTERLEAVED, 44100, 0);
tsf_note_on(TSF, 0, 48, 1.0f);
for (int i = 0; i < 5; i++)
{
tsf_render_float(TSF, Buf, BUFFER_WINDOW, 0);
fwrite(Buf, sizeof(Buf), 1, f);
}
tsf_close(TSF);
fclose(f);
Hopefully we can figure this one out (-:
\ Bernhard
from tinysoundfont.
It was more than 1 sample per render portion, also seemingly more than zero, but still distorted - and indeed it was the lowpass filter causing this; your latest commit produced a beautiful piano sound (with the help of the right soundfont)! Thanks! #nicelib
from tinysoundfont.
Awesome to hear! Super stoked we found that one!
Thanks again for reporting.
from tinysoundfont.
Related Issues (20)
- How many channels does this support? HOT 2
- white noise unexpected sound when playing the files HOT 2
- Stuck instrument with Windows XP onestop.mid HOT 1
- Incompatibility with ISO C++ HOT 2
- `TSF_MALLOC(...)` without non-NULL check/error handling HOT 3
- Design issue: having playback handling and soundfont in same structure incentivizes people to write memory hogs(?) HOT 3
- `tsf_set_max_voices()` should actually be enforced HOT 2
- Unicode open HOT 1
- Would be possible to sustain a note? HOT 2
- Is .sfz support something devs consider also thank you for the library HOT 6
- voices active for slightly longer than they should be
- Reading samples directly at runtime (port to STM32) HOT 1
- MIDI latency HOT 1
- Likely memory leak in use of TSF_REALLOC in new sf3 code in out of memory conditions HOT 1
- Player ending before end of music (not playing last notes)
- [Question] Loading multiple SF2 files?
- soundnames inside drumkits
- large soundfonts HOT 2
- Dynamic Voice Allocation and Immediate Cutoff Mechanism Proposal for Memory Optimization in SoundFont Library HOT 1
- Extending sfotool support with optional sample load callback. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tinysoundfont.