Giter VIP home page Giter VIP logo

Comments (3)

kushkella avatar kushkella commented on August 13, 2024

I think the solution is to change the add_foreign_key method to set default name. Something like this

        def add_foreign_key(*args) # (table_name, column, to_table, primary_key, options = {})
          options = args.extract_options!
          case args.length
          when 2
            from_table, to_table = args
          when 4
            ActiveSupport::Deprecation.warn "4-argument form of add_foreign_key is deprecated.  use add_foreign_key(from_table, to_table, options)"
            (from_table, column, to_table, primary_key) = args
            options.merge!(column: column, primary_key: primary_key)
          end

          options = options.dup
          options[:column] ||= foreign_key_column_for(to_table)
          options[:name]   ||= ForeignKeyDefinition.default_name(from_table, options[:column])

          foreign_key_sql = add_foreign_key_sql(from_table, to_table, options)
          execute "ALTER TABLE #{quote_table_name(from_table)} #{foreign_key_sql}"
        end

from schema_plus.

ronen avatar ronen commented on August 13, 2024

@kushkella Yes that looks right. Care to add a (failing) spec that tests this, then make the above fix?

from schema_plus.

kushkella avatar kushkella commented on August 13, 2024

Sure, will do.

from schema_plus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.