Comments (5)
The Serializer Class calls in line 141 the visitor getResult method. Through the ArrayCollectionHandler is the result always set and therefore never the ArrayCollection returned. Possibly the handler should reset the result of the visitor?
// JMS\Serializer\Serializer Line 141
if ((null === $visitorResult = $visitor->getResult()) && null !== $navigatorResult) {
return $navigatorResult;
}
// JMS\Serializer\Handler\ArrayCollectionHandler Line 53
return new ArrayCollection($visitor->visitArray($data, $type));
from serializer.
I came across this issue today while making a custom handler for a class similar to ArrayCollection.
I resolved it by cloning the visitor inside my deserialize method, which prevented the original visitor from being filled with the array result of the visitor.
Are there any known issues that would result from cloning the visitor as such?
public function deserialize(VisitorInterface $visitor, $data, array $type, Context $context)
{
$type['name'] = 'array';
$myVisitor = clone $visitor;
return new ScalarParameterMap($myVisitor->visitArray($data, $type, $context));
}
from serializer.
@schmittjoh This is happening as of 0.16.0 and @Engerim pointed at the issue already.
from serializer.
I had the same problem when implementing a handler for my collections.
I realized that the serializer was ignoring the result of my handler because the result of the visitor is not null
// ...jms/serializer/src/JMS/Serializer/Serializer.php
private function handleDeserializeResult($visitorResult, $navigatorResult)
{
// This is a special case if the root is handled by a callback on the object itself.
if (null === $visitorResult && null !== $navigatorResult) {
return $navigatorResult;
}
return $visitorResult;
}
What I did was re-set the navigator. This makes the result of the visitor set to null
public function deserialize(JsonDeserializationVisitor $visitor, $data, array $type, Context $context)
{
/**
* @var $collection ArrayCollection
*/
$collection = new $type['name'];
self::assertValidArrayCollectionSubclass($collection);
$items = $this->getItems($visitor, $type, $data, $context);
foreach ($items as $item) {
$collection->add($item);
}
$visitor->setNavigator($visitor->getNavigator());
return $collection;
}
from serializer.
Fixed in 2.0, now the visitors do not use an internal data representation, but the data are passed always back an forward to the graph navigator and serialized/deserialized with the new SerializationVisitorInterface::getResult($data) and DeserializationVisitorInterface::getResult($data) methods
from serializer.
Related Issues (20)
- Type Error in XmlDeserializationVisitor.php when switching to PHP 8 HOT 3
- The serializer cannot be installed in a Laravel version 10 project. HOT 2
- Update doctrine/instantiator to v2.x for PHP 8.1 HOT 5
- JMS serializer implements Symfony serializer HOT 4
- "Can't use incorrect type integer for collection" on PHPDoc-typed integer, boolean or double HOT 1
- stdClass Serialization Does Not Use Property Naming Strategy HOT 3
- Question: How to handle de-/serializing unions (using native type hints)? HOT 5
- Serialization of Symfony\Component\Mime\Address HOT 4
- Undefined property: JsonDeserializationVisitor::$navigator sence version 3.23 HOT 2
- The dependency on doctrine/annotations should become an optional one HOT 2
- Minor Issue from Triggering Autoload Before Expanding Class Names HOT 2
- ORM 3.0 Compat HOT 8
- Adding tideways spans inside JMS serializer HOT 5
- Serialization of objects with missing attribute errors HOT 2
- AccessType attribute constructor expects array HOT 3
- Feature request: Allow literal discriminator values HOT 2
- Use another field than "id" to find Doctrine entity HOT 3
- Change to optional Doctrine/Annotations package introduces a breaking change HOT 10
- Enum deserializer
- Missing fields are replaced with null HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from serializer.