Giter VIP home page Giter VIP logo

Comments (4)

ChrisRackauckas avatar ChrisRackauckas commented on August 22, 2024 1

I see, so this can close. I'll mark the others as broken. In general it's just not good to have tests commented out and instead they should be @test_broken anyways, since that will let you know if they unbreak.

from integrals.jl.

ChrisRackauckas avatar ChrisRackauckas commented on August 22, 2024

@lxvm you said the PR fixed these, did you try the tests? Maybe we can just uncomment them?

from integrals.jl.

lxvm avatar lxvm commented on August 22, 2024

Yes, I uncommented the associated tests in #175. In #191 the additional uncommented tests are for derivatives with respect to boundaries, which are missing for the forward pass, and missing for dim>1 in the reverse pass. I'll take a swing at it in the next week or two

from integrals.jl.

lxvm avatar lxvm commented on August 22, 2024

Thanks for bearing with me! I'm still learning a lot about best practices for writing packages

from integrals.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.