Comments (13)
This is the prod repo, the dev repo is https://github.com/0x6d69636b/windows_hardening
from hardeningkitty.
Yup looking good! My bad haha.
from hardeningkitty.
Thank you for the update 👍
from hardeningkitty.
What parameters did you use to start HardeningKitty? Is it possible to run it without any file parameter? If so, HardeningKitty will create a file in the same directory where it is started from
from hardeningkitty.
What parameters did you use to start HardeningKitty? Is it possible to run it without any file parameter? If so, HardeningKitty will create a file in the same directory where it is started from
Iirc I gave it the logging one but the path to the log file didnt exist (no "tmp" folder on the root of the c drive)
from hardeningkitty.
If you only use -Log without -LogFile, HardeningKitty will generate the file name for you and save the file it in the current folder. I'm uncertain what the default behaviour should be: report that the path does not exist, create a temporary file, create all non-existent folders, or... ;-)
from hardeningkitty.
Considering context of Kitty and accidentally passing an incorrect path and not getting a backup / log could leave a system in an undesirable state. Maybe stop the execution if the passed path doesnt exist or create the path.
from hardeningkitty.
I added checks for log, report, and backup file path, HardeningKitty stops if the path does not exist:
0x6d69636b/windows_hardening@f6079cf
from hardeningkitty.
When are we running this check, I pulled the recent version and havent triggered your fix yet, should'nt we make sure the log file can be created at the path before proceeding?
from hardeningkitty.
I don't like tools or scripts that create folders on my systems, so I prefer to stop HardeningKitty rather than create directories. On the one hand, I understand your use case, but on the other hand, if the log file path has a typo in it or is otherwise wrong, it would be uncool to create the full path
from hardeningkitty.
I don't like tools or scripts that create folders on my systems, so I prefer to stop HardeningKitty rather than create directories. On the one hand, I understand your use case, but on the other hand, if the log file path has a typo in it or is otherwise wrong, it would be uncool to create the full path
Yeah sort of like idempotence. Sorry just wanted to clarify I downloaded the change you made and I still ran into the issue, below is the command im using to test. Shouldnt we make sure that if Kitty is to write something to the disk as requested by the user, we should make sure the path is valid before checking the system with kitty itself.
We would be wasting resources checking the whole system just to tell the user at the end that we cant write to the non existant directory.
- If user provides a directory, make sure the path is valid
- Now check the system with kitty
And here is the test command im using
Invoke-HardeningKitty -Mode Config -Report -ReportFile C:\tmp\my_hardeningkitty_report.csv
from hardeningkitty.
Agreed. The check takes place during the initialisation phase, and if the path does not exist, execution will be aborted. In your case, you should only receive the message "The path to your report file does not exist.". Can you make sure you're using the latest version from the dev repo?
from hardeningkitty.
Agreed. The check takes place during the initialisation phase, and if the path does not exist, execution will be aborted. In your case, you should only receive the message "The path to your report file does not exist.". Can you make sure you're using the latest version from the dev repo?
Dev repo?
from hardeningkitty.
Related Issues (20)
- Category Windows Firewall clarification HOT 8
- XblGameSave Standby Task, 11060 HOT 4
- Automatic creation of finding lists HOT 1
- The finding list was not found HOT 1
- CIS 22H2 list availability HOT 2
- Which rules from finding_list_0x6d69636b_machine.csv affect RDP? HOT 1
- Mishandling of "Never minutes" in Account Lockout Duration checks HOT 5
- Which rules from finding_list_cis_microsoft_windows_server_2022_21h1_1.0.0_machine affect RDP? HOT 14
- Requires Admin Privilege HOT 1
- unauthenticated guest access HOT 3
- finding_list_cis_microsoft_windows_server_2022_21h2_1.0.0_machine.csv - ID 2.3.10.9, Network access: Remotely accessible registry paths and sub-paths HOT 3
- Registry to Local Group Policy? HOT 1
- question HOT 17
- question about scripts HOT 3
- Incorrect Control ID in win10 Enterprise 22h2 189.7.1.5.1 HOT 1
- CIS baseline in combination with Intune HOT 2
- About Creating a Group Policy HOT 1
- Check how to execute the function Create a Group Policy (experimental) added from v0.91 HOT 4
- Windows defender blocked HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hardeningkitty.