Giter VIP home page Giter VIP logo

Comments (7)

arzoo14 avatar arzoo14 commented on August 26, 2024

@v0dro While building travis, this error is coming
An error occurred while loading spec_helper.
Failure/Error: require 'grruby.so'
LoadError:
cannot load such file -- grruby.so

Also , travis build is showing remaining rubocops offences.
How to fix both of these ? Please guide !

from rubyplot.

v0dro avatar v0dro commented on August 26, 2024

Rubocop offenses you can fix. As for GR, just remove the lines in rubyplot.rb that requires the GR framework and any other things related GR. We will support that later.

from rubyplot.

v0dro avatar v0dro commented on August 26, 2024

Also, please direct future PRs to master branch.

from rubyplot.

arzoo14 avatar arzoo14 commented on August 26, 2024

Rubocop offenses you can fix. As for GR, just remove the lines in rubyplot.rb that requires the GR framework and any other things related GR. We will support that later.

Many of the rubocop offenses , now needing changes like Metrics/Method length, method parameter name, cyclomatic complexity where I need to change code accordingly to remove them. So am I allowed to make new definitions and change parameters name to remove these offenses ?

from rubyplot.

v0dro avatar v0dro commented on August 26, 2024

Ah. In that case just send a PR with the .travis.yml file and proper configuration. I will make the appropriate changes for rubocop. Its ok if the tests fail.

from rubyplot.

v0dro avatar v0dro commented on August 26, 2024

@arzoo14 can you make a modification to the rubocop that allows comments after end. For example I want:

end # class Base

and not:

end
# class Base

from rubyplot.

arzoo14 avatar arzoo14 commented on August 26, 2024

@arzoo14 can you make a modification to the rubocop that allows comments after end. For example I want:

end # class Base

and not:

end
# class Base

Done PR #31

from rubyplot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.