Giter VIP home page Giter VIP logo

Comments (4)

praiskup avatar praiskup commented on July 24, 2024 1

This is what I was missing:
ct_os_cluster_running && echo "Cluster already running. Nothing is done." && return 0

So it is not that bad - but still, going forward if the cluster is down (that's the case for most contributors ATM, I guess), does it make sense to even attempt to disable firewall etc. when I'm rarely run the build under non-root user? And if user accidentally runs this under root, it changes his system config..

from container-common-scripts.

pkubatrh avatar pkubatrh commented on July 24, 2024

We could have some script for user's convenience (doing the oc installation), but the images in CI should be as much prepared as possible, same as user's boxes -- and we should only provide the login info into the openshift instance.

Isn't this the current state? There is a separate function ct_os_install_in_centos that installs the rpms needed for Centos but does not have to be invoked in the test suite.

from container-common-scripts.

praiskup avatar praiskup commented on July 24, 2024

Aha, ct_os_install_in_centos is not in postgresql-container#209 anymore - good; but there's still ct_os_cluster_up, which doesn't seem to be safe (root-only stuff).

from container-common-scripts.

pkubatrh avatar pkubatrh commented on July 24, 2024

So it is not that bad - but still, going forward if the cluster is down (that's the case for most contributors ATM, I guess), does it make sense to even attempt to disable firewall etc. when I'm rarely run the build under non-root user? And if user accidentally runs this under root, it changes his system config..

Ah right, that is true. So a better way to do this would be to expect an already prepared cluster along with some information to access it. And fail if neither of these is provided.

Might be worthwhile to change the issue name to something more appropriate to the problem at hand.

from container-common-scripts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.