Comments (4)
This is what I was missing:
ct_os_cluster_running && echo "Cluster already running. Nothing is done." && return 0
So it is not that bad - but still, going forward if the cluster is down (that's the case for most contributors ATM, I guess), does it make sense to even attempt to disable firewall etc. when I'm rarely run the build under non-root user? And if user accidentally runs this under root, it changes his system config..
from container-common-scripts.
We could have some script for user's convenience (doing the oc installation), but the images in CI should be as much prepared as possible, same as user's boxes -- and we should only provide the login info into the openshift instance.
Isn't this the current state? There is a separate function ct_os_install_in_centos
that installs the rpms needed for Centos but does not have to be invoked in the test suite.
from container-common-scripts.
Aha, ct_os_install_in_centos
is not in postgresql-container#209 anymore - good; but there's still ct_os_cluster_up
, which doesn't seem to be safe (root-only stuff).
from container-common-scripts.
So it is not that bad - but still, going forward if the cluster is down (that's the case for most contributors ATM, I guess), does it make sense to even attempt to disable firewall etc. when I'm rarely run the build under non-root user? And if user accidentally runs this under root, it changes his system config..
Ah right, that is true. So a better way to do this would be to expect an already prepared cluster along with some information to access it. And fail if neither of these is provided.
Might be worthwhile to change the issue name to something more appropriate to the problem at hand.
from container-common-scripts.
Related Issues (20)
- Print info about container image tested in test.sh HOT 4
- generator.py fails the sanity check HOT 2
- Failure in case of OpenShift 4 connect
- docker --iidfile unknown flag HOT 1
- Traceback in cgroupt-limits HOT 1
- In case of '.git' directory does not exist build and tag is failing.
- regression in 'ct_clean_app_images' HOT 2
- Stop tests on SIGINT HOT 3
- Test log output improvements needed HOT 3
- Make sure that failed test in the end always fails the testsuite
- database library would be nice for mysql, mariadb and postgresql containers
- OCP tests: Make sure that failed test in the end always fails the testsuite HOT 2
- Do not try to get compressed image size when tests are interrupted HOT 4
- stop rebuild and testing of centos7 images HOT 1
- Migrate fedora images to f38 where possible HOT 5
- grep: warning: stray \ before - HOT 3
- Review hotfix for removing set -e from test-lib HOT 1
- Remove dead branches and set delete on merge as default HOT 1
- Fix check_latest_imagestreams.py HOT 1
- Adjust bot for common submodule updates.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from container-common-scripts.