issue with make syntax error about container-common-scripts HOT 7 CLOSED

Any clues? :/

Thanks for the report. I would bet the build.sh runs the default /bin/bash (shebang), which is the old shell version 3, right?

from container-common-scripts.

@hhorak - dare suppose you have any idea about this?

from container-common-scripts.

#!/bin/bash

^ that is indeed 3.2!

from container-common-scripts.

make SHELL=/your/path/to/bash could be allowed with:

diff --git a/common.mk b/common.mk
index a3fffce..833b0c2 100644
--- a/common.mk
+++ b/common.mk
@@ -3,11 +3,13 @@
 # If set to '0', images are automatically squashed.  '1' disables
 # squashing.  By default only RHEL containers are squashed.
 
+SHELL := /bin/bash
+
 ifndef common_dir
     common_dir = common
 endif
 
-build = $(common_dir)/build.sh
+build = $(SHELL) $(common_dir)/build.sh
 test = $(common_dir)/test.sh
 tag = $(common_dir)/tag.sh
 clean = $(common_dir)/clean.sh

from container-common-scripts.

I updated the shebang to "#!/usr/bin/env bash -e" - which I believe is more widely compatible, I believe?

That fixed it.. :)

from container-common-scripts.

The -e is weird, but otherwise such change would sound safe..

from container-common-scripts.

@bobbydeveaux Hopefully 44fb885 fixes the error you have been having. Please re-open in case you find any issue with it.

from container-common-scripts.