Comments (5)
praiskup
commented on July 4, 2024
It's not portable shell idiom, and so I don't like that (as a lot of things in that document).
OTOH, if we feel it is worth it... we don't care much about portability in this project, so
I have no strong opinion.
from container-common-scripts.
hhorak
commented on July 4, 2024
I wanted just to hear more opinions, not that I'd push on that either. Thanks for the feedback so far, I'd keep this open to see more feedback, but I agree that without a good reason to change it, it's not worth it.
from container-common-scripts.
omron93
commented on July 4, 2024
In my point of view, portability of this project isn't so important. But I'm also thinking if the readability of the new format is so better, that it makes sense to rewrite tests for several images...
from container-common-scripts.
pkubatrh
commented on July 4, 2024
Imo the readability improves by a bit but I do not think it is worth the change, considering we would need to change all of the images to the new format (or keep both for compatibility I guess)
from container-common-scripts.
hhorak
commented on July 4, 2024
I agree it's not worth it, closing.
from container-common-scripts.
Related Issues (20)
- Do shellcheck on PR code HOT 1
- make image availability test quicker
- move check_result to common HOT 2
- Analyze container cleanup after tests
- Add trap on ERR if exit on error bash option is enabled
- Print info about container image tested in test.sh HOT 4
- generator.py fails the sanity check HOT 2
- Failure in case of OpenShift 4 connect
- docker --iidfile unknown flag HOT 1
- Traceback in cgroupt-limits HOT 1
- In case of '.git' directory does not exist build and tag is failing.
- regression in 'ct_clean_app_images' HOT 2
- Stop tests on SIGINT HOT 3
- Test log output improvements needed HOT 3
- Make sure that failed test in the end always fails the testsuite
- database library would be nice for mysql, mariadb and postgresql containers
- OCP tests: Make sure that failed test in the end always fails the testsuite HOT 2
- Do not try to get compressed image size when tests are interrupted HOT 4
- stop rebuild and testing of centos7 images HOT 1
- Migrate fedora images to f38 where possible HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from container-common-scripts.