build.sh uses bash feature incompatible with OS X about s2i-python-container HOT 10 CLOSED

@mnagy [ -v TEST ] does not seems to work for me on OS X.

hack/build.sh: line 73: [: -v: unary operator expected

If [[ is preferred and the convention, it seems reasonable to require OS X users to update bash with homebrew or use a linux VM. They are already jumping through some amount of hoops to get docker running.

I leave it to your expert opinions.

from s2i-python-container.

@bparees @csrwng i think we should fix this for all scripts in all our images, right?

from s2i-python-container.

yes 👍

from s2i-python-container.

I haven't run into this because I usually replace the default OS X bash with the latest one installed from brew.

from s2i-python-container.

@dlbewley [ also supports -v. Does OS X bash not support -v? If not, then I suggest we use -n "${TEST_MODE:-}", at least in scripts that do not tolerate usage of unset variables.

from s2i-python-container.

though it's a bit religious, [[ seems to be generally preferred(more full featured) and not all that new, i'm surprised OSX has an issue:

http://stackoverflow.com/questions/669452/is-preferable-over-in-bash-scripts

but I won't stand in the way if one of you mac users wants to fix it :)

from s2i-python-container.

@bparees yeah, I prefer [[ as well... but recently I learned OSX bash sux :-) (unless you install the latest bash from homebrew, which is what I'm doing ;-)

from s2i-python-container.

FWIW, even upcoming MacOS X High Sierra will still have the same old bash version, likely because newer versions use GPL V3 and so Apple will avoid it. Personally I don't like installing bash through Homebrew, as as a developer who releases my own packages, I need to ensure I am writing scripts which will work with the system bash version.

My preference therefore is to use syntax that works with older bash version. Since I need to get ability to build working on MacOS X to test some of the current PRs, I'll create a PR to use older syntax.

from s2i-python-container.

AFAIK this should be fixed for some time already (in build.sh at least) since we had a similar request for this over at sclorg/container-common-scripts#17

from s2i-python-container.

Okay. Seems have moved to git sub modules for the stuff as well so not even in this repo anymore.

So can someone close this then if has been addressed.

from s2i-python-container.