Giter VIP home page Giter VIP logo

Comments (8)

mfojtik avatar mfojtik commented on July 21, 2024

@rhcarvalho do you mean .bashrc? If so, then I think I agree (if you have .bashrc in your source repository, then you loose the SCL enable and you will be broken. We should set the HOME directory to one level up and add the .bashrc there maybe.

@bparees ideas?

from s2i-python-container.

soltysh avatar soltysh commented on July 21, 2024

👍 it's a leftover from the time when we had the ONBUILD actions defined in base image.

from s2i-python-container.

bparees avatar bparees commented on July 21, 2024

applies to more than python.

from s2i-python-container.

bparees avatar bparees commented on July 21, 2024

is there a reason this would be a problem to fix post-3.0? if not, i suggest we do that.

from s2i-python-container.

mfojtik avatar mfojtik commented on July 21, 2024

@bparees i think I'm OK with fixing this post-3.0, but I don't see this as too much devel work.

from s2i-python-container.

rhcarvalho avatar rhcarvalho commented on July 21, 2024

@mfojtik I mean all of contrib/'s content, see this, which includes src/.bashrc and now also src/passwd.template.

@bparees yes, applies to all images. I wouldn't create one issue per image, and didn't create the issue in sti-base because the is no copying there.

from s2i-python-container.

soltysh avatar soltysh commented on July 21, 2024

Trelloed, please close.

from s2i-python-container.

rhcarvalho avatar rhcarvalho commented on July 21, 2024

sti-* have already been changed before, moving away from contrib/src to contrib/etc.

from s2i-python-container.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.