Determine approach to GovernorCountingFractional.hasVoted about flexible-voting HOT 3 CLOSED

I just looked through sourcegraph and I'm not seeing a ton of usage of this function in solidity contracts. Mostly it's just used in tests. Here's an example that looks for a false hasVoted to determine if an account can vote or not. Returning false when partial votes have been cast would sort of break this, i.e. the user could still vote again with partial weight. But in context this is fine, since projects like this one vote with full weight anyway.

I still need to look for usage in JS/frontend code

from flexible-voting.

Alright, here's a sourcegraph query for frontend usage. Some notes:

• nearly a third of all matches (56 of 157) are in tests
• no really big/popular Web3 projects are using this (there are some popular-ish web2 projects, but the hasVoted they are using isn't the governance function we care about)
• the biggest web3 project that seems to use it is Unlock, but even they only use it in a one-off utility script which could be easily updated

So it really feels like we can kind of do what we want here. There's not much usage of this function either in existing contracts or in existing frontends.

Additionally, the approach we are currently taking (returning true if any amount of votes have been cast by the user on the proposal) should be backwards compatible with most uses of hasVoted, since presumably those contexts would also be using the nominal castVote function, which votes with full weight. If your protocol always votes with full weight, then a hasVoted implementation that returns true when any weight is cast will still behave the way you expect.

from flexible-voting.

We should create a getter function to expose the currently private _proposalVotersWeightCast[proposalId][user] mapping. This way users who do care about partial votes can identify when a partial voter has used all of his/her weight

from flexible-voting.