Spec 3.2.2: Indicate preferences applied about lakesuperior HOT 5 CLOSED

Tests for the Prefer header are here.

from lakesuperior.

So I was looking at this one here. But it seems like you only apply certain headers, certain ways.

I'm still really unclear how this all works together (haven't got debugging in pycharm setup). But you probably need to account for both include and omit for all possible Preferences.

See https://jira.duraspace.org/projects/FCREPO/issues/FCREPO-3037 for an example of how we didn't account for this. I'll just try to account for the Preferences you are handling for now and it can be expanded later.

from lakesuperior.

That function gets some "include/omit" values from parse_rfc7240 in https://github.com/scossu/lakesuperior/blob/master/lakesuperior/util/toolbox.py#L75 and sets some defaults based on whether representation=minimal is set. Then it flips some defaults based on certain "include" and "omit" conditions. I am not checking for conditions that would not change the existing default. I may have not written extensive testing but I believe this is meant to cover all combinations; unless you are referring to conditions that I am not aware of (note that I wrote this server based on the Fedora 4 REST API documentation).

The simplest and most efficient way to debug requests for me is to add import pdb; pdb.set_trace() where you want a breakpoint, then fire up lsup-server (the blocking Flask app, not the WSGI server that may time out if you hold up a request) in one shell and send an HTTP request in another, then follow the execution with pdb commands.

from lakesuperior.

How or from where do I run the test suite?

from lakesuperior.

From the git repo root: pytest

Or pytest -x to quit on first failure.

from lakesuperior.