Bug for CommitAt about go-junos HOT 6 CLOSED

Yup, you are correct! Thanks for catching that! I’ll have it fixed in the morning!

_{Sent with GitHawk}

from go-junos.

Should be all set!

from go-junos.

Thanks for fixing this. I have some question about why using an array for message, since you are only taking the first array element as commit message, why not just use a string ?

`
func (j *Junos) CommitAt(time string, message ...string) error {
var errs commitResults
command := fmt.Sprintf(rpcCommitAt, time)

if len(message) > 0 {
	command = fmt.Sprintf(rpcCommitAtLog, time, message[0])
}

`

from go-junos.

So, this is more so a functionality of Golang and trying to use "optional" parameters in functions. I could just have a static param, and check to see if it's set like:

CommitAt(time string, message string)

...

if len(message) > 0 { do stuff }

But I wanted to make the function easier on the user so that if they forgot to put a message by some chance, it wouldn't error out at them. If the last parameter is a ...string then that means you could have many optional parameters, but they would all be message[0], message[1], ... etc.

from go-junos.

... i think i understand .... message[0] for commit message and other parameters for other purposes, is this right ?

from go-junos.

Yup, you got it.

from go-junos.