OS X compilation issue about pcs2 HOT 20 OPEN

the cmake setup is probably incorrect, and there's 3rd party files just chucked in with the PCS2 code. i.e. GLee is 3rd party & should be moved to src/glee.

Or maybe it should be changed to be more like fso; and move all 3rd party stuff into ../lib/DIR (including fmt, pugixml & Glee)

from pcs2.

Maybe @asarium can offer some suggestions on fixing the cmake config?

from pcs2.

Yeah if that's the way to get per-project compilation options it probably needs to be done. I think older compilers were more lax about this, older LLVM apparently treated it as a warning. Now it's a halting error.

from pcs2.

ah yes, g++ on 'buntu 16.04 is still treating it as a warning so I didn't worry too much about it before...

from pcs2.

Benklop's got a fix for it - we're just testing it and if we can get it to work he'll submit the fix.

from pcs2.

C++11 is supposed to be handled by the CMake function target_compile_features. Apparently that is currently not used by the PCS2 CMake setup.

from pcs2.

@countbuggula any news on the fix being tested by Benklop?

from pcs2.

Since FreeBSD is using a new clang version as well, this is also blocking PCS2 from compiling there. Any word on a solution to getting our third party libs from using the same defines as our C++ code?

from pcs2.

@countbuggula ping :)

from pcs2.

Bueller?

from pcs2.

from pcs2.

After looking into this, it actually seemed to have come from fmt's own CMake config file. fmt avoids setting the CPP11_FLAG argument if a CXX standard is defined within CMake already, so I tested defining one on the command line and that caused this error to stop. A solution therefore might be to permanently define the C++11 standard within our main CMake files and the fmt one should avoid setting it in a way that conflicts with C files.

from pcs2.

A solution therefore might be to permanently define the C++11 standard within our main CMake files

I think this has been done. Can this be closed?

from pcs2.

I haven't tried compiling PCS2 in ages so I can't confirm or deny this is still an issue. I can try it again on my Macbook and see if something similar is still happening. But if we see an actual change has been made to the repo to account for this since it was filed, then we can go ahead and close it out and I'll file a new or reopen this if I run into any issues next time I try compiling it.

from pcs2.

I don't actually know for sure whether the change has been made. I thought it had been, but I don't have a Mac to check.

from pcs2.

I'm following up with Benklop again to see if he remembers submitting any changes.

from pcs2.

I was thinking more like just looking at the PR history, would myself but lazy since I keep replying to this thread when I'm on my phone

from pcs2.

From Benklop:
"The laptop I was testing on Sat the time very much died, I'm sure if I found a solution I would have submitted it so you'd see it in the commit history"

from pcs2.

I do have a mac now too, just a different one. I can try and confirm this issue or its resolution some time this week.

from pcs2.

Still getting:

CompileC build/src/PCS2.build/Debug/pcs2.build/Objects-normal/x86_64/GLee.o src/GLee.c normal x86_64 c com.apple.compilers.llvm.clang.1_0.compiler
    cd /Users/cliff/PCS2
    export LANG=en_US.US-ASCII
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x c -target x86_64-apple-macos10.15 -fmessage-length=221 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -fcolor-diagnostics -Wno-trigraphs -fpascal-strings -O0 -Wno-missing-field-initializers -Wno-missing-prototypes -Wno-return-type -Wno-missing-braces -Wparentheses -Wswitch -Wno-unused-function -Wno-unused-label -Wno-unused-parameter -Wno-unused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wno-constant-conversion -Wno-int-conversion -Wno-bool-conversion -Wno-enum-conversion -Wno-float-conversion -Wno-non-literal-null-conversion -Wno-objc-literal-conversion -Wno-shorten-64-to-32 -Wpointer-sign -Wno-newline-eof -DCMAKE_INTDIR=\"Debug\" -DILUT_USE_OPENGL -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__ -D__WXOSX_COCOA__ -DUNIX -DHAVE_SYS_TYPES_H -DHAVE_SYS_STAT_H -DHAVE_UNISTD_H -DUSE_SDL -DBOOST_ALL_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_REGEX_DYN_LINK -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -Wno-sign-conversion -Wno-infinite-recursion -Wno-comma -Wno-block-capture-autoreleasing -Wno-strict-prototypes -Wno-semicolon-before-method-body -I/Users/cliff/PCS2/build/src/Debug/include -I/Users/cliff/PCS2/src/pugixml -I/Users/cliff/PCS2/src/../res -I/usr/local/include/IL -I/usr/local/lib/wx/include/osx_cocoa-unicode-3.0 -I/usr/local/include/wx-3.0 -I/Users/cliff/Library/Frameworks/SDL.framework/Headers -I/Users/cliff/PCS2/src/fmt -isystem /usr/local/include -I/Users/cliff/PCS2/build/src/PCS2.build/Debug/pcs2.build/DerivedSources-normal/x86_64 -I/Users/cliff/PCS2/build/src/PCS2.build/Debug/pcs2.build/DerivedSources/x86_64 -I/Users/cliff/PCS2/build/src/PCS2.build/Debug/pcs2.build/DerivedSources -F/Users/cliff/PCS2/build/src/Debug -F/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks -F/Users/cliff/Library/Frameworks -fPIE -std=c++11 -g -MMD -MT dependencies -MF /Users/cliff/PCS2/build/src/PCS2.build/Debug/pcs2.build/Objects-normal/x86_64/GLee.d --serialize-diagnostics /Users/cliff/PCS2/build/src/PCS2.build/Debug/pcs2.build/Objects-normal/x86_64/GLee.dia -c /Users/cliff/PCS2/src/GLee.c -o /Users/cliff/PCS2/build/src/PCS2.build/Debug/pcs2.build/Objects-normal/x86_64/GLee.o
error: invalid argument '-std=c++11' not allowed with 'C'
Command /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang failed with exit code 1

** BUILD FAILED **

from pcs2.