Giter VIP home page Giter VIP logo

Comments (2)

VMRuiz avatar VMRuiz commented on August 24, 2024 2

Hello @wRAR , this is related to how itemloaders build the items.

What's happening here is that ItemLoader will create an instance of ArticleItem without values. Because of that, the user_rating is set to -999 during the instance creation, and ItemLoader will assume as the first value discovered to that field. This is the same behaviour as to passing an already pre-filled dictionary to an item loader:

>>> loader = RappiLoader(item={"user_rating": 2.5})
>>> loader.add_value("user_rating", 0)  # Add fallback value in case user_rating was not defined 
>>> loader.load_item()
{'user_rating': 2.5}

In this case however, the expectation would be to keep the initial value already provided.

I think this shouldn't be fixed. The list of values are always added in the same order. Then, is up to the user to decide what to do with them - e.g. select the first one, last one, all of them, apply some filters, or manipulate them-.

You can implementing a custom selector that fits your needs.

from itemloaders.

wRAR avatar wRAR commented on August 24, 2024

Moving this to itemloaders, though on a second thought (and without checking any code) it may be, though not likely, itemdapter-specific.

from itemloaders.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.