Giter VIP home page Giter VIP logo

Comments (12)

Gago55 avatar Gago55 commented on August 24, 2024 7

Hello, dear Secret Network community.
Congratulations to all of us 🎉 one more problem was solved for our network.

The proposal is completed, and we have up and running Secret Contract Verifier - http://secret-contracts.com.
The source code is in https://github.com/Gago55/Secret-Contract-Verifier.
Also, we have done an extra feature, after successful verification of Code (Secret Contract) the source will be automatically pushed to https://github.com/secretcontracts , and we will have all verified Codes (Secret Contracts) in one familiar place too.

Little bit details:
As you can see the proposal was approved on May 12
We received the first disbursement on May 20 and started to work on it the next day
We worked hard to finish the project on time and done it in 40 days as we predicted

We had a demonstration meeting today with @reuvenpo @toml01
We consider the project finished.

Thanks to all who supported us, specially @reuvenpo and @cankisagun

from grants.

PrivatePixels avatar PrivatePixels commented on August 24, 2024 2

This is awesome!😎

We will give credit when we implement it on the explorer.🤙🏾

from grants.

assafmo avatar assafmo commented on August 24, 2024 1

Hi @Gago55 and @manvelarz! Thanks for this submission.

This feature is indeed something I personally wanted since before mainnet, but both explorers did not have the capacity to implement it.

I believe that an additional web app is not needed here, and this should be integrated into an explorer. In the blockchain itself everything is ready for this (builder and source fields), and it's now a matter of implementing reproducible builds for contracts (which might be not that easy [1][2][3]) and setting standards for contract builders of how to use the builder and source fields when uploading a new contract to the blockchain.

So to summarize my thoughts:

  • Instead of the web app, I'd like to see an integration plan with at least https://secretnodes.com (Cc @moonstash @jacobtjackson). Bonus points for @Cashmaney.
  • I'd like to see a plan for reproducible builds, because right now I doubt it'll take 5-10 days to achieve this.

Again, thank you for wanting to improve Secret Network!

from grants.

reuvenpo avatar reuvenpo commented on August 24, 2024 1

100% on Assaf's comment, but I'll add that for contracts that didn't set builder and source fields, or set them incorrectly, there should still be an option to submit the parameters to this application independently, like you have proposed.

from grants.

assafmo avatar assafmo commented on August 24, 2024 1

Hi guys, nice work!
Where are the instructions for contact developers on how to make their code verified? And is it possible to turn an unverified code into a verified one?

from grants.

manvelarz avatar manvelarz commented on August 24, 2024

@assafmo , @reuvenpo

Instead of the web app, I'd like to see an integration plan with at least https://secretnodes.com

Our intend is to create an open source app, so any interested one can take and use it. Maybe someone will upgrade it and keep the source closed or better, contribute his source. In any single case Secret Network will benefit incrementally. So The OPEN SOURCE ideology will start to benefit to our network and users too.
Our vision is that the web app will be the foundation for feature open source explorer for Secret Network. Ideally it will be at https://explorer.scrt.network/. We are planning to propose the Open source explorer after finishing this project. The benefit in doing in this sequence is that other explorers can start to integrate this functionality meanwhile we will be working in creation of open source explorer.

I'd like to see a plan for reproducible builds, because right now I doubt it'll take 5-10 days to achieve this.

I don't understand your point. Do you mean  reproducible builds without the Secret-Contract-Optimizer docker?
Because with that docker in our understanding Contracts are reproducible. We've tried and succeeded(achieved blockchain's Hashes) on reproduction of several contracts, Including SSCRT(CodeID-5) and ETH-reward(CodeID-23).


Quote from www.secret.foundation

The mission of Secret Foundation is to support the global adoption of open-source, privacy-centric technologies that help protect and empower users around the world.

from grants.

PrivatePixels avatar PrivatePixels commented on August 24, 2024

@assafmo , @reuvenpo

Instead of the web app, I'd like to see an integration plan with at least https://secretnodes.com

Our intend is to create an open source app, so any interested one can take and use it. Maybe someone will upgrade it and keep the source closed or better, contribute his source. In any single case Secret Network will benefit incrementally. So The OPEN SOURCE ideology will start to benefit to our network and users too.

Our vision is that the web app will be the foundation for feature open source explorer for Secret Network. Ideally it will be at https://explorer.scrt.network/. We are planning to propose the Open source explorer after finishing this project. The benefit in doing in this sequence is that other explorers can start to integrate this functionality meanwhile we will be working in creation of open source explorer.

I'd like to see a plan for reproducible builds, because right now I doubt it'll take 5-10 days to achieve this.

I don't understand your point. Do you mean  reproducible builds without the Secret-Contract-Optimizer docker?

Because with that docker in our understanding Contracts are reproducible. We've tried and succeeded(achieved blockchain's Hashes) on reproduction of several contracts, Including SSCRT(CodeID-5) and ETH-reward(CodeID-23).


Quote from www.secret.foundation

The mission of Secret Foundation is to support the global adoption of open-source, privacy-centric technologies that help protect and empower users around the world.

The community pool already funded an open source block explorer with 250k scrt last year. That work which is still open source, has since turned into the secretnodes.com community explorer which is fully maintained and improved upon based on a self sustainable model that allows us to not ask for additional funding in relation to the explorer. We would be happy to use our resources to incorporate the work you are proposing on the contract verifier if you're willing to work with us, otherwise the feature is already on our roadmap and we will simply do it ourselves (though we'd prefer to collaborate to the max extent there is interest for / that makes sense).

Furthermore, we still intend to open source additional parts of the explorer so we consider ourselves as already running the open source explorer for the community you are describing.

from grants.

assafmo avatar assafmo commented on August 24, 2024

I don't understand your point. Do you mean reproducible builds without the Secret-Contract-Optimizer docker?
Because with that docker in our understanding Contracts are reproducible. We've tried and succeeded(achieved blockchain's Hashes) on reproduction of several contracts, Including SSCRT(CodeID-5) and ETH-reward(CodeID-23).

Secret-Contract-Optimizer docker does not guarantee reproducible builds.

from grants.

reuvenpo avatar reuvenpo commented on August 24, 2024

To clarify, the docker helps with creating reproducible builds, but the full process requires support from the contract itself. Additionally, many of the issues described in the links Assaf posted above apply to specific architectures and specific binary formats. I understand that most of those do not apply to Wasm code that is compiled without backtraces, in a controlled environment (where paths are well known).
This work requires some experimentation to see what is possible and what poses a challenge. I am pretty sure though that if someone builds the contract locally without the docker image, reproducing the build becomes harder, but I also think that all the users have to do in that case is also provide information about what version of Rust was used, what build features were enabled, and what directory the build ran on in the programmer's machine.

from grants.

reuvenpo avatar reuvenpo commented on August 24, 2024

I want to clarify that i fully support this grant application 💯 🙂
The discussion above is technical discussion and guidance, and not criticism - secret contracts can be reproducible and most uploaded contracts have been built in a reproducible way. The team behind this proposal have already demonstrated being able to reliably verify several live contracts.

from grants.

cankisagun avatar cankisagun commented on August 24, 2024

This proposal is approved.

from grants.

manvelarz avatar manvelarz commented on August 24, 2024

Hi @assafmo . I've prepared a video instruction and I hope it will respond to your second question. Please take a look.
Video tutorial

from grants.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.