'dtype' within reading functions doesn't work about anndata HOT 7 CLOSED

update:

The 'dtype' is missing in _read_text()

    return AnnData(data,
                   obs={'obs_names': row_names},
                   var={'var_names': col_names})

Similarly, in transpose() and copy(),etc, it's missing too

from anndata.

It should be present in _read_text, right and the other reading function! That's a bug. Would you mind making a pull request?

It shouldn't be present in transpose and copy, though.

from anndata.

Sure. I will do that.

But I noticed for the function transpose() , if I don’t add dtype = float64, after read_text() and transpose, it will be reverted to float32 again . I guess there must be something else that needs to be fixed.

from anndata.

Hi Alex,

Thanks again for developing this amazing package for python community. I was wondering if you have any updates on the data type issue. I'll be happy to pull request if you could let me know besides reading functions all the other functions I should look at.

Many thanks!

Best,
Huidong

from anndata.

Sorry for being so slow, @huidongchen , it's been fixed for copy (989f13e) and for transpose (b7dca41).

The PR for the read functions will only affect the read functions themselves. Should be very straight forward. Thank you!

from anndata.

Hi Alex @falexwolf thanks a lot for updating other relevant parts. I will make a PR shortly.

from anndata.

Fixed via #81.

from anndata.