Giter VIP home page Giter VIP logo

Comments (4)

jeff-regier avatar jeff-regier commented on August 16, 2024 1

Yes, that might work. Maybe call it Trainer, with train as a method.

from scvi-tools.

Edouard360 avatar Edouard360 commented on August 16, 2024

Would creating a Train class also work ? Where we would inherit a loop method, ect... ?

I feel like a single function with flags would be less readable.

from scvi-tools.

Edouard360 avatar Edouard360 commented on August 16, 2024

I went from ~180 to ~100 lines in branch trainer, in train.py which includes modifications from branch refactoring therefore aiming at solving also #76 and #75.

Do you agree with the Trainer class design ? (which might be refined before the pull request)

from scvi-tools.

jeff-regier avatar jeff-regier commented on August 16, 2024

Yes, looks like a nice improvement.

from scvi-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.