Additional features for pl.spatial function about squidpy HOT 7 CLOSED

Does the refactor of the scatterplot module include moving the code for spatial plotting out of sc.pl.embedding?

from squidpy.

Not sure what's @flying-sheep opinion on this. So far, pl.spatial is essentially a wrapper of sc.pl.embedding with a couple of additions:

• function to process images and plot them
• use of "circles" (from PatchCollection) instead of "scatter"

from squidpy.

Yeah, we added a bit more to what’s already too many options. No idea how to nicely deprecate and replace it by something better, and that didn’t change by those additions.

I think the best would be to extract the image-below-things to sc.pl.spatial, but leave the option to do circles instead of markers.

from squidpy.

I don't think those options have been documented in a release. Can we just not document them for the regular embedding functions?

Really, a lot of those plotting functions could be more modular.

from squidpy.

Yeah. If nobody picks up the slack until I’m done with my thesis, I’ll do it after. But it’s really a thing we need.

from squidpy.

Could we make sure that those arguments don't get documented in a release? Also, I think the doc builds have been broken since the wishbone PR. It might be worth asking read the docs to enable doc builds for our PRs.

from squidpy.

closed with #437

from squidpy.