Giter VIP home page Giter VIP logo

Comments (2)

pietroborrello avatar pietroborrello commented on August 23, 2024

It seems that the check in DsaLocal at line 667 is specifically made for one or several gep instructions starting from NULL.

if (!m_graph.hasCell(*LI.getPointerOperand()->stripPointerCasts())) {

Here the crash is acually a load of a pointer, which is obtained from a load on a GEP null, so two levels of indirection:

  %arrayidx87.us = getelementptr inbounds i8*, i8** null, i64 %indvars.iv99
  %arrayidx.us = bitcast i8** %arrayidx87.us to float**
  %4 = load float*, float** %arrayidx.us, align 8, !tbaa !4
  %6 = bitcast float* %4 to i32*
  %7 = load i32, i32* %6, align 4, !tbaa !8

It is undefined behavior, but it is present due to UBSan.
I can submit a PR to fix this, but not sure what I should check, instead of simply transforming assert(!base.isNull()); into if(base.isNull()) return; in:

assert(!base.isNull());

Probably the fix should avoid creating the null cell in the first place.

from sea-dsa.

pietroborrello avatar pietroborrello commented on August 23, 2024

Ok if I enable assertions with PR #131 it actually crashes on

assert(false && "Expression not handled");

after printing as a warning: Unexpected expression at valueCell: %4 = load float*, float** %arrayidx.us, align 8, !tbaa !4 .
This while in visitBitCastInst visiting %6 = bitcast float* %4 to i32* with %4 = load float*, float** %arrayidx.us, align 8, !tbaa !4

from sea-dsa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.