Giter VIP home page Giter VIP logo

Comments (7)

seansfkelley avatar seansfkelley commented on August 23, 2024

Oh boy. Given that this happens with "test connection", this must have been caused by the fix to #32, which increased the API version used for logging in to prevent it from overriding the browser's session cookies.

It seems reasonable to reintroduce this to support old versions, with a caveat. I'm thinking:

  • synology-typescript-api should accept a version parameter for the API calls
  • The extension should check if the NAS supports a sufficient version of the auth API. If it does, change nothing. If it doesn't, drop down to using the old API version but warn the user (probably with a link to #32).

Auditing synology-typescript-api for usages of version !== 1 will likely help prevent these issues in the future.

from nas-download-manager.

hoyeung3407 avatar hoyeung3407 commented on August 23, 2024

It seems to be the solution, hope it is acceptable for other users too.
Thank you very much !

from nas-download-manager.

seansfkelley avatar seansfkelley commented on August 23, 2024

@hoyeung3407 in the mean time, you can use version 0.2.1 which shouldn't have this issue (though also with fewer features). I'm hoping to get a fix out in the next couple days!

from nas-download-manager.

hoyeung3407 avatar hoyeung3407 commented on August 23, 2024

Oh, you're very helpful. Thank you.

from nas-download-manager.

seansfkelley avatar seansfkelley commented on August 23, 2024

Should be fixed by 6df62e8.

from nas-download-manager.

hoyeung3407 avatar hoyeung3407 commented on August 23, 2024

You're a lifesaver !
Updated to version 0.4.1 and it works again.
Very quick response and update, thank you !

from nas-download-manager.

seansfkelley avatar seansfkelley commented on August 23, 2024

Yay! Thanks for verifying for me.

from nas-download-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.