Comments (8)
I think for the average case where there is only one column as primary key, adding one container layer is counter intuitive.
But perhaps, we can make an associated type def in the PrimaryKeyTrait
impl PrimaryKeyTrait for PrimaryKey {
type ValueType = i32;
}
from sea-orm.
How we handle composite primary keys?
from sea-orm.
Composite primary keys can't be auto generated, and so it's less important. But I think the type could be a tuple, if we really try to support it. Let's leave it and return 0 for now.
from sea-orm.
I think this issue can be related to #101 if we have an attribute primary_key
. Then, we can derive a struct to represent value of returning columns (primary keys).
from sea-orm.
And btw... returning statement in Postgres can return multiple columns at once.
https://www.postgresql.org/docs/current/dml-returning.html
from sea-orm.
Adding type def is a good suggestion
from sea-orm.
I've had a dive into the code for this.. it seems like adding ValueType
on the PrimaryKeyTrait would work great!
Then perhaps InsertResult
can be given a generic:
pub struct InsertResult<T> {
pub last_insert_id: T,
}
And exec
on Insert
could return the value type as the generic type:
impl Future<
Output = Result<InsertResult<<A::Entity as EntityTrait>::PrimaryKey::ValueType>, DbErr>
>
This what I'm thinking would be the best way..
from sea-orm.
Agreed.
from sea-orm.
Related Issues (20)
- does postgres int8 work? HOT 2
- [Testing] Error: `A null value was encountered while decoding "num_items"` when testing pagination and counting HOT 1
- support sqlx v0.8 HOT 1
- sea-orm-cli 1.0 doesn't support mysql type: `bit` HOT 2
- VarBinary(16) column breaks DeriveEntityModel derive
- sea-orm-cli 1.0 generate entity from mysql generates String for MediumBlob fields
- Timezone offset information lost when reading a ChronoDateTimeWithTimeZone HOT 1
- Cannot run sea-orm-cli with feature codegen without sqlite as a dependency HOT 1
- `schema::custom()` requires `col` and `name` to be of same type
- Vec<RoleEnum> in SeaORM Entity Model Causes Compilation Error HOT 1
- No reference to features list or alternate DB connectors in docs.
- Support for `HashMap`
- `sea-orm-migration` is missing the `sqlx-all` feature
- Incorrect type in entity generation
- `ColumnDef` builder functions in `sea-orm-migration` may push additional statements instead of changing them HOT 2
- Allow the use of SmartString for strings
- issue with Migrator::up, the trait bound `&sea_orm::DatabaseConnection: IntoSchemaManagerConnection<'_>` is not satisfied HOT 2
- Generated entities: "the trait bound `Option<Vec<Vec<u8>>>: TryGetable` is not satisfied"
- Double insert when using String as primary key HOT 1
- No way to set `max_lifetime` and `idle_timeout` to None for database connections
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sea-orm.