`InsertResult` to return the primary key's type about sea-orm HOT 8 CLOSED

I think for the average case where there is only one column as primary key, adding one container layer is counter intuitive.
But perhaps, we can make an associated type def in the PrimaryKeyTrait

impl PrimaryKeyTrait for PrimaryKey {
    type ValueType = i32;
}

from sea-orm.

How we handle composite primary keys?

from sea-orm.

Composite primary keys can't be auto generated, and so it's less important. But I think the type could be a tuple, if we really try to support it. Let's leave it and return 0 for now.

from sea-orm.

I think this issue can be related to #101 if we have an attribute primary_key. Then, we can derive a struct to represent value of returning columns (primary keys).

from sea-orm.

And btw... returning statement in Postgres can return multiple columns at once.
https://www.postgresql.org/docs/current/dml-returning.html

from sea-orm.

Adding type def is a good suggestion

from sea-orm.

I've had a dive into the code for this.. it seems like adding ValueType on the PrimaryKeyTrait would work great!
Then perhaps InsertResult can be given a generic:

pub struct InsertResult<T> {
    pub last_insert_id: T,
}

And exec on Insert could return the value type as the generic type:

impl Future<
  Output = Result<InsertResult<<A::Entity as EntityTrait>::PrimaryKey::ValueType>, DbErr>
>

This what I'm thinking would be the best way..

from sea-orm.

Agreed.

from sea-orm.