Giter VIP home page Giter VIP logo

Comments (8)

imbabamba avatar imbabamba commented on June 26, 2024

also:

image

from backstage-plugins.

imbabamba avatar imbabamba commented on June 26, 2024

still issues with upload and missing image element

from backstage-plugins.

zhammer avatar zhammer commented on June 26, 2024

hi @imbabamba. thanks for raising this with us.

do you have user authentication set up on your backstage instance? the awards backend requires user authentication to run:

This plugin relies on [Backstage authentication](https://backstage.io/docs/auth/)
in order to enforce ownership of awards. Please follow the documentation to
enable authentication before attempting to use this plugin!
.

this looks like it may be an issue where a user token isn't set up and so the auth layer is sending an "Access Denied".

if you do have auth set up on your production instance but not on your local instance, you can try adding something like we did to your local config to get a "dummy" auth system running: https://github.com/seatgeek/backstage-plugins/blob/main/packages/backend/src/plugins/auth.ts.

from backstage-plugins.

imbabamba avatar imbabamba commented on June 26, 2024

@zhammer hi.

First of all, awesome plugin! and thanks for replying!

I will look into the backend 2 backend auth again. But what about the emtpy 'preview' element issue? Also would be great if "Aspect ration 3:1" text could be changed to like 150x50 px and warn about a more reasonable image size since most users wont understand which size is actually needed to get it to work.

from backstage-plugins.

zhammer avatar zhammer commented on June 26, 2024

for the image preview issue, can you reload your page with network inspector on and check what the response on that image is? i'm not sure what's going on there.

agreed that the aspect ratio instruction is a little confusing. there's also rules on image size (max and min) on the backend that aren't clearly expressed there. i can take a look on how this is expressed on other UIs.

from backstage-plugins.

imbabamba avatar imbabamba commented on June 26, 2024

It appears when no image is selected.

image

if I remove this element, all looks good. Feels like it being invoked wrongly or maybe an "example" picture should be here instead. (looked like there were one on the demo you guys had.

from backstage-plugins.

zhammer avatar zhammer commented on June 26, 2024

ah, this may just be some poor UI carried over from a change when this used to be autopopulated, it's not anymore. if you want to push up a change where that image element isn't rendered at all when there's no image uploaded yet, i'm happy to approve.

<Grid item>
<img alt="" src={awardImage} height="200" width="600" />
</Grid>

from backstage-plugins.

imbabamba avatar imbabamba commented on June 26, 2024

I can wait til you have changed this. :)

from backstage-plugins.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.