clean up saveModel handling of model types about incidence-mapper HOT 4 OPEN

I didn't see that property. That makes perfect sense to grab it from definition if it is specified there since it is more scalable to future model types

from incidence-mapper.

turns out it wasn't quite that simple, since all models make smooth/observed models. Anyway, I'll put in a pull request soon as I think I have worked out what we need going forward on the branch. But it will break some assumptions in the server--we can talk next week. But thanks for getting it up so we can see what it looks like!

from incidence-mapper.

saveModel in general has a lot of code duplication and confusing flow. Clean up the whole thing when we get to it.

from incidence-mapper.

Hooking up new model types, as will be required on branch https://github.com/seattleflu/incidence-mapper/tree/famulare/flu-vax-efficacy is basically impossible with the current modelServR::saveModel design, which assumes two model types. Fixing saveModel to be more extensible and maintainable is necessary, and merging in flu-vax-efficacy models is a good prompt to do so. However, the viz can't do anything with these models right now, and they are fast to run, so I don't need this functionality until after clean-alpha-deployment is finished.

from incidence-mapper.