image_science leaks whenever the ReOrient function is called. In the following code sn

I sent a pull request after testing this with eomernick. See <a class="issue-link js-i

Memory leak in ReOrient function about image_science HOT 2 CLOSED

seattlerb commented on September 17, 2024

Memory leak in ReOrient function

from image_science.

Comments (2)

eomernick commented on September 17, 2024

Looking at the FreeImage documentation it looks like you need to call the FreeImage_Unload function to avoid leaks.

Maybe something like this:

  FIBITMAP* ReOrient(FIBITMAP *bitmap) {
      FITAG *tagValue = NULL;
      FIBITMAP *newBitmap;  
      FreeImage_GetMetadata(FIMD_EXIF_MAIN, bitmap, "Orientation", &tagValue);
      switch (tagValue == NULL ? 0 : *((short *) FreeImage_GetTagValue(tagValue))) {
        case 6:
          newBitmap = FreeImage_RotateClassic(bitmap, 270);
          break;
        case 3:
          newBitmap = FreeImage_RotateClassic(bitmap, 180);
          break;
        case 8:
          newBitmap = FreeImage_RotateClassic(bitmap, 90);
          break;
        default:
          newBitmap = FreeImage_Clone(bitmap);
         break;
      }
    FreeImage_Unload(bitmap);
    return newBitmap;
  }

The Documentation can be found here: http://iweb.dl.sourceforge.net/project/freeimage/Source%20Documentation/3.15.4/FreeImage3154.pdf

Page 12 of the document has the unload method (page 16 of the pdf).

EDIT: I just tested this code using the original script and it seems to work without leaking memory.

from image_science.