Giter VIP home page Giter VIP logo

Comments (3)

sebastianbergmann avatar sebastianbergmann commented on August 16, 2024

Thank you for your report.

Please provide a minimal, self-contained, reproducing test case that shows the problem you are reporting.

Without such a minimal, self-contained, reproducing test case I will not be able to investigate this issue.

from phpunit.

kkmuffme avatar kkmuffme commented on August 16, 2024

Here's a really basic one (of course not very realistic, but it's minimal and self-contained). Same thing also (more realistic) is possible with exception handler

<?php declare(strict_types=1);
/*
 * This file is part of PHPUnit.
 *
 * (c) Sebastian Bergmann <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace PHPUnit\TestFixture;

use function set_error_handler;
use function trigger_error;
use PHPUnit\Framework\TestCase;

class SomeExternalDependency {
    public function __construct()
    {
        set_error_handler([$this, 'logError']);
    }

    private function logError(): bool
    {
        return false;
    }
}

class Issue5844Test extends TestCase
{

    public function testSetErrorHandlerNonCallable(): void
    {
        new SomeExternalDependency();

        trigger_error('error', E_USER_WARNING);

        $this->assertTrue(true);
    }
}

from phpunit.

mvorisek avatar mvorisek commented on August 16, 2024

Here is an repro: https://3v4l.org/GFd18

The issue is the callback must be restored in rebound context. I belive reflection can be used to detect the target context.

Here is docs https://www.php.net/manual/en/language.types.callable.php for all supportted callable types. All possibly private/not-callable-from-non-this must be tested.

php/php-src#14494 should be linked as IMO it is a little flaw in php design/callable validation on set_error_handler.

from phpunit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.