`add(path/to/folder/)` results in folder name to be incorrectly set to `/` about zipper HOT 5 CLOSED

@devnoname120 have you tried that fixed? if it worked and every test is passing, would you submit a pull request?

Thanks!

from zipper.

I will try to make a pull request when I get the chance to.

from zipper.

I think it's a bad idea to handle paths as std::string with a few helper functions. It leads to some unforeseen issues such as this one and the one described in this issue.

I suggest that we switch to C++17's std::filesystem::path with an optional fallback to boost::filesystem::path.

from zipper.

And with that we come full circle :) ... @sebastiandev originally was using of course C++17, which made the library available pretty much only on windows. I've tried with several fall back systems (using boost or Qt). But ultimately to have it working on most systems (and yes, even older linux kernel versions), for us it was necessary to revert to the solution with helper functions.

from zipper.

Add unit tests inside the v2.x.y branch. Reopen this ticket if not fixed.

from zipper.