Zip created by zipper can not be extracted using Windows or Win zip about zipper HOT 3 CLOSED

I'm probably wrong but the add() method takes an ifstream not a stringstream (see unit tests as example)

from zipper.

@Lecrapouille: It takes any istream.

@AlexSolaris:
I was already working on my Win10 VM, so I gave it a shot.
I had the following code (in main.cpp):

#include <zipper/zipper.h>
#include <sstream>

int main()
{
	zipper::Zipper zipper("ziptest.zip");
	
	std::stringstream ss;
	ss << "TEST";
	zipper.add(ss, "stuff.txt");
	
	zipper.close();
	
	return 0;
}

Compiled with:

cl /MD /EHsc /IC:\Projects\lib\zipper main.cpp C:\Projects\lib\zipper\release\libzipper-static.lib "C:/Program Files/zlib/lib/zlibstatic.lib"

Then running main.exe creates a ziptest.zip file, which opened fine both with 7Zip and Windows 10's Explorer.

** Disclaimer: This test might be worthless because in my copy of Zipper the code is a little outdated and modified a little bit, but not in any way that I suspect could make much difference.
Edit: Checked again with the most recent code from master. No problem opening the zip file with Windows Explorer or 7Zip.

from zipper.

Closing this ticket is working (at least on Linux on my side, I cannot test on window). Feel free to reopen this ticket if needed

from zipper.