Giter VIP home page Giter VIP logo

Comments (7)

sebastiandev avatar sebastiandev commented on July 17, 2024

Hey, yep i missed that one. good catch. Wanna make a pull request for this change?

Thanks!

from zipper.

alexbala avatar alexbala commented on July 17, 2024

I'm new to github. I've made an account just to write the previous comment :) I don't know how to make a pull request.

from zipper.

sebastiandev avatar sebastiandev commented on July 17, 2024

ah no problem, i'll make those changes and let you know!
thanks!

from zipper.

Blacklands avatar Blacklands commented on July 17, 2024

Hey,
Just wanted to ask, has this been fixed in the "master" branch yet? I see there's a pull request apparently dealing with it; has that been merged in?
If not, I could try to make all those changes and do a pull request myself, if you want (never did this before though).
Would be happy about a reply, since I'm looking forward to using this library soon! :)

from zipper.

fbergmann avatar fbergmann commented on July 17, 2024

I already have a pull request pending that includes the binary streams ... so i don't think another pull
request is needed at this point.

cheers
frank

from zipper.

Blacklands avatar Blacklands commented on July 17, 2024

I saw that one, I just wasn't sure if it was really related to the problem, and if it was already merged in or not (still new to GitHub, to my defense).
Thanks for letting me know this, though! I hope it'll get merged in sometime soon.

from zipper.

sebastiandev avatar sebastiandev commented on July 17, 2024

merged! sorry i didn't notice the pr before. enjoy :)

from zipper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.