`.secretlintignore` does not work in Windows about secretlint HOT 8 CLOSED

@risu729 Thanks for PR!
No problem. I will merge your PR soon.

I'll file my suggestion as another issue.

from secretlint.

This will be fixed in v7.0.4

Thanks for PR!

from secretlint.

Can you paste your .secretlintignore?

from secretlint.

Updated the original comment!

from secretlint.

Thanks.

Probably, current implement has an issue on Windows, I think.

However, globby has supported ignoreFiles option at recent.
Switing current implemention to ignoreFiles option that may resolve this issue.

• sindresorhus/globby: User-friendly glob matching
  • Release v13.1.0 · sindresorhus/globby

from secretlint.

Remove ignore option for isGitIgnored and isGitIgnoredSync (sindresorhus/globby#225) sindresorhus/globby@2e43cc4
This option never worked correctly.
Release v13.0.0 · sindresorhus/globby

current implementation uses ignore option. We need to update globby and use ignoreFiles.

TODO

• Add missing test case
• Update globby
• Move DEFAULT_IGNORE_PATTERNS to options.ignore from ignore
  • https://github.com/sindresorhus/globby#options
• Use ignoreFiles option as needed

from secretlint.

Thank you for your information. It seems better than my solution!
Can I close my PR?

from secretlint.

• #592

I created a separate Issue for the remaining tasks.

from secretlint.