Giter VIP home page Giter VIP logo

Comments (4)

J12934 avatar J12934 commented on July 4, 2024

Hi @Alon-Katz

Not 100% sure but this might be a helm / crd upgrade issue.
Helm install installs the CRD of the chart but helm upgrade does not upgrade it on changes.

We normally have a seperate head up warning about having to manually update the CRDs when the release had CRDs changes, but I forgot to add it to the 4.4.0 release.

So the CRD changes are in the release but not yet in your cluster so kubernetes doesn't allow you to use it yet.

I've updated the description of the release to now contain this notice, see:

https://github.com/secureCodeBox/secureCodeBox/releases/tag/v4.4.0

kubectl apply -f https://raw.githubusercontent.com/secureCodeBox/secureCodeBox/v4.4.0/operator/crds/cascading.securecodebox.io_cascadingrules.yaml	
kubectl apply -f https://raw.githubusercontent.com/secureCodeBox/secureCodeBox/v4.4.0/operator/crds/execution.securecodebox.io_clusterparsedefinitions.yaml	
kubectl apply -f https://raw.githubusercontent.com/secureCodeBox/secureCodeBox/v4.4.0/operator/crds/execution.securecodebox.io_clusterscancompletionhooks.yaml	
kubectl apply -f https://raw.githubusercontent.com/secureCodeBox/secureCodeBox/v4.4.0/operator/crds/execution.securecodebox.io_clusterscantypes.yaml	
kubectl apply -f https://raw.githubusercontent.com/secureCodeBox/secureCodeBox/v4.4.0/operator/crds/execution.securecodebox.io_parsedefinitions.yaml	
kubectl apply -f https://raw.githubusercontent.com/secureCodeBox/secureCodeBox/v4.4.0/operator/crds/execution.securecodebox.io_scancompletionhooks.yaml	
kubectl apply -f https://raw.githubusercontent.com/secureCodeBox/secureCodeBox/v4.4.0/operator/crds/execution.securecodebox.io_scans.yaml	
kubectl apply -f https://raw.githubusercontent.com/secureCodeBox/secureCodeBox/v4.4.0/operator/crds/execution.securecodebox.io_scantypes.yaml	
kubectl apply -f https://raw.githubusercontent.com/secureCodeBox/secureCodeBox/v4.4.0/operator/crds/execution.securecodebox.io_scheduledscans.yaml

from securecodebox.

Alon-Katz avatar Alon-Katz commented on July 4, 2024

Hi @J12934 , I tested this on a new Minikube instance with a fresh installation of SecureCodeBox v4.4.1, and I also tried to apply the CRD you provided, but the issue persists.

from securecodebox.

J12934 avatar J12934 commented on July 4, 2024

Should be fixed with release v4.5.0 :)
Can you check if this resolves the issue for you?

from securecodebox.

Alon-Katz avatar Alon-Katz commented on July 4, 2024

Hi @J12934 , Thanks for the quick release!
Seems like there is still an error, tried both with --set and with a values.yaml file (New minikube instance with a fresh install of v4.5.0 and also ran the crds apply just in case)

This is the set command:
helm upgrade --install new-scanner secureCodeBox/gitleaks --set parser.nodeSelector."beta\\.kubernetes\\.io/os"=linux -n securecodebox-system

This is the same in values.yaml file:

parser:
    nodeSelector:
        beta.kubernetes.io/os: linux

Same result in both methods

W0317 19:07:37.250238   40628 warnings.go:70] unknown field "spec.nodeSelector.beta.kubernetes.io/os"
Error: UPGRADE FAILED: failed to create resource: ParseDefinition.execution.securecodebox.io "gitleaks-json" is invalid: spec.nodeSelector.nodeSelectorTerms: Required value

from securecodebox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.