Giter VIP home page Giter VIP logo

Comments (2)

itsdouges avatar itsdouges commented on June 4, 2024

That said then code split chunks don't work — I imagine it's because of passing code from root to frame and it then having assumptions about the level path not being met anymore. 🤔

from playroom.

itsdouges avatar itsdouges commented on June 4, 2024

Okay removed the publicPath and added support for both frame.html and frame/index.html

diff --git a/node_modules/playroom/lib/makeWebpackConfig.js b/node_modules/playroom/lib/makeWebpackConfig.js
index 6ca8355..35debf4 100644
--- a/node_modules/playroom/lib/makeWebpackConfig.js
+++ b/node_modules/playroom/lib/makeWebpackConfig.js
@@ -171,6 +171,12 @@ module.exports = async (playroomConfig, options) => {
         chunks: ['frame'],
         filename: 'frame.html',
       }),
+      new HtmlWebpackPlugin({
+        title: 'Playroom Frame',
+        chunksSortMode: 'none',
+        chunks: ['frame'],
+        filename: 'frame/index.html',
+      }),
       new HtmlWebpackPlugin({
         title: 'Playroom Preview',
         chunksSortMode: 'none',
  • having our own frameSrc function:
export const frameSrc = (
  { code, themeName }: { code: string; themeName: string },
  { baseUrl, paramType }: { baseUrl: string; paramType: 'hash' | 'search' },
) => {
  const isBifrostEnvironment = baseUrl.includes('assets/');
  const actualBaseUrl = isBifrostEnvironment
    ? baseUrl.replace('assets/', '') + 'frame'
    : baseUrl + 'frame.html';

  return `${actualBaseUrl}${
    paramType === 'hash' ? '#' : ''
  }?themeName=${encodeURIComponent(themeName)}&code=${encodeURIComponent(
    code,
  )}`;
};

I think this will work. Our infra smdh :- )

Might end up closing this TBH because there isn't much to be done. Just going to close this. Either way we're playing around with Playroom atm to help test some things 👋

from playroom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.