Comments (2)
That said then code split chunks don't work — I imagine it's because of passing code from root to frame and it then having assumptions about the level path not being met anymore. 🤔
from playroom.
Okay removed the publicPath
and added support for both frame.html
and frame/index.html
diff --git a/node_modules/playroom/lib/makeWebpackConfig.js b/node_modules/playroom/lib/makeWebpackConfig.js
index 6ca8355..35debf4 100644
--- a/node_modules/playroom/lib/makeWebpackConfig.js
+++ b/node_modules/playroom/lib/makeWebpackConfig.js
@@ -171,6 +171,12 @@ module.exports = async (playroomConfig, options) => {
chunks: ['frame'],
filename: 'frame.html',
}),
+ new HtmlWebpackPlugin({
+ title: 'Playroom Frame',
+ chunksSortMode: 'none',
+ chunks: ['frame'],
+ filename: 'frame/index.html',
+ }),
new HtmlWebpackPlugin({
title: 'Playroom Preview',
chunksSortMode: 'none',
- having our own
frameSrc
function:
export const frameSrc = (
{ code, themeName }: { code: string; themeName: string },
{ baseUrl, paramType }: { baseUrl: string; paramType: 'hash' | 'search' },
) => {
const isBifrostEnvironment = baseUrl.includes('assets/');
const actualBaseUrl = isBifrostEnvironment
? baseUrl.replace('assets/', '') + 'frame'
: baseUrl + 'frame.html';
return `${actualBaseUrl}${
paramType === 'hash' ? '#' : ''
}?themeName=${encodeURIComponent(themeName)}&code=${encodeURIComponent(
code,
)}`;
};
I think this will work. Our infra smdh :- )
Might end up closing this TBH because there isn't much to be done. Just going to close this. Either way we're playing around with Playroom atm to help test some things 👋
from playroom.
Related Issues (20)
- Version 0.27.7 throws when no TS config file is found HOT 1
- Custom Icons
- Improve themes documentation
- Shared links are broken HOT 3
- Custom fonts/static assets HOT 4
- Reduce the gap showing TS errors 👀
- Checkbox logic could be improved
- componentsToHints breaks if `PlayRoomProps.components` file contains something other than a component
- Dark mode shadows
- React 18 support HOT 5
- v0.28.x fails on project using @vanilla-extract/next-plugin HOT 1
- v0.28.x HOT 2
- [Feature Request] Detach code panel to separate window
- Gitlab Addon HOT 1
- With prettier V3, opening code snippets generate an error HOT 1
- Feature Request: Support `Cmd + /` to comment out code
- Code given to frames aren't compressed HOT 6
- Editor for an additional css / scss file HOT 1
- Windows machine giving Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: from version 0.33.0 upwards HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from playroom.