Giter VIP home page Giter VIP logo

Comments (2)

ianstormtaylor avatar ianstormtaylor commented on May 29, 2024

Things I noticed while going through:

  1. Looks like the version number (0.0.1) is out of date? Would be good if we injected this from a single source place so that we only have to update in one spot.
  2. Looks like the created_at dates for the identify calls are missing the T in the ISO date format of the string. Wherever there are dates we probably need to make this change.
  3. Seeing first and last name traits as firstname and lastname, but they should be first_name and last_name to stay consistent.
  4. Looks like I see a "gender": false in there, but we should just hide it if one doesn't exist.
  5. Search results pages should be Search Results instead of Search results for: 'test' so that we don't have an unbounded amount of page names.

We're getting super close! This is looking awesome man

from analytics-magento.

astorm avatar astorm commented on May 29, 2024

Opened new issues for items above.

from analytics-magento.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.