evergreen-buttons outline about evergreen HOT 4 CLOSED

I like this!
Still not sure how I feel about referring to colors by name though.
I know it is unlikely that we'd change our brand colors anytime soon, but I still enjoy using abstractions such as danger and primary.

I don't feel strongly about this though, just my 2 cents.

from evergreen.

Love the timely feedback, keep them coming 👍 @nettofarah thanks for the input!

How it is currently implemented in the React UI Library (internal Segment library) It is kind of hard to pull the trigger on changing what primary means. Blue buttons will become more used throughout our app in the future as a primary button, green will reserved a more severe primary actions such as creating new things. Primary is very much a relative term, in a Dialog the primary button might be blue, whereas in a creation form it might be green.

That being said, I think there is still place for a primary and danger abstraction, but in our application:

const DangerButton = props => <Button appearance='red' {...props} />
const PrimaryButton = props => <Button appearance='green' {...props} />

// Or something like
const SemanticColors = {
   primary: colors.green['500'],
   danger: colors.red['500']
}

from evergreen.

Sounds good to me!
I'm sold :)

from evergreen.

Implemented, see #13.

from evergreen.