Giter VIP home page Giter VIP logo

Comments (4)

Rowno avatar Rowno commented on May 22, 2024

I vote for SelectMenu. Also for using Downshift for the accessibility.

Also what's the difference between evergreen-select-menu and evergreen-select-menu-popover?

from evergreen.

jeroenransijn avatar jeroenransijn commented on May 22, 2024

@Rowno one would be inside of a Popover, so you can simply wrap it around a Button. It's for convenience. Otherwise engineers will need to do some plumbing every time they want to use this, instead of simply passing in items and a onSelect. What do you think?

from evergreen.

Rowno avatar Rowno commented on May 22, 2024

Would you ever use evergreen-select-menu though?

from evergreen.

jeroenransijn avatar jeroenransijn commented on May 22, 2024

@Rowno probably not, it's probably better to export multiple components from the same package instead:

import SelectMenu, { SelectMenuStandalone } from 'evergreen-select-menu'

from evergreen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.