Why are tag paths validated against r"^[a-zA-Z0-9][a-zA-Z0-9_]*[a-zA-Z0-9]$"? about pyasdf HOT 7 CLOSED

Similarly, why are uppercase letters not allowed in the names of the provenance datasets?

from pyasdf.

Hi Brad,

sorry for the delay on this. I've been on vacation.

Why are tag path names validated against r"^[a-zA-Z0-9][a-zA-Z0-9_]*[a-zA-Z0-9]$"? This is more restrictive than the naming scheme used in /Waveforms. For example /AuxiliaryData/NET.STA/MYDATASET_NAME would not be allowed due to the . in NET.STA. It would be nice to allow consistency in the layout between /Waveforms and /AuxiliaryData.

This has been done a while ago and I'm no longer 100 percent certain why it is restricted as such. I think there is no deeper reason for not allowing dots aside from no longer being able to offer convenient attribute access to the auxiliary data sets in Python.

But this is programming language specific and should not inhibit the data format. I'd be fine with changing it.

Similarly, why are uppercase letters not allowed in the names of the provenance datasets?

Again no proper reason I can recall aside from this just being how we practically implemented it. I think this should definitely be changed.

Both of these are fairly minor changes which should not have a large effect. If noone else does it I would do this early next week and create version 1.0.3 of ASDF and make the necessary changes to pyasdf. Are there any other small nagging issues you are having in regards to these things?

from pyasdf.

We are happy with the ASDF layout and naming conventions other than these two small issues.

from pyasdf.

@krischer It would be great if you could provide this fix in the next week. We are waiting on this fix to release our ground-motion processing software that stores everything using ASDF.

from pyasdf.

I just released pyasdf version 0.5.0 on pypi: https://pypi.org/project/pyasdf/0.5.0/
I'll try to get the conda packages done today but the pypi ones are already alive.

This implements ASDF version 1.0.3 and I also updated the format definition and the validator in the corresponding repositories.

from pyasdf.

Alright 0.5.1 is life on conda and pypi. I hope all is good now. Let me know if there are still some issues.

from pyasdf.

Everything looks good so far.

from pyasdf.