Comments (5)
Hi @garydevenay
I noticed you're using http.DetectContentType(contents)
to determine the content type, instead of reading the type parsed from the email by inbound.Parse
. Is the content type parsed from the email using the inbound helper correct?
from sendgrid-go.
Hi @eshanholtz
Thanks for the reply. As I understand contents
is a map[string][]byte
containing the file contents with the filename as the key (Reference) Is there a separate property of ParsedEmail
that contains the content type?
from sendgrid-go.
Ah, my apologies. There is a ParsedEmail.Headers
property that reads headers from the email, but the Content-Type
header you would end up reading from there is multipart/mixed
. I was able to recreate your issue using http.DetectContentType
on our test email attachments. I think the best path forward here would be to extend the inbound module to give Attachments
its own ParsedAttachment
struct type, with its own Headers
, Filename
, and Content
properties. The Headers
property would be populated based on the data in the emailPart
's Header
property.
This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.
from sendgrid-go.
@eshanholtz Created a PR for the above solution.
from sendgrid-go.
Update on the above:
The solution above (including my amendments) still doesn't actually work with attachments. All attachments that come through inbound parse are corrupt.
I can't make any more progress on this as I'm unable to test Inbound Parse's requests on a non-production environment and the provided unit tests aren't a reflection of Inbound Parse's POST request.
This either needs to be looked at by a core member or Twilio/Sendgrid need to supply us with a valid method of testing this locally, but the service does not work as it stands.
from sendgrid-go.
Related Issues (20)
- GoDoc: “Doc” not displayed due to license restrictions.
- Go Modules Support HOT 4
- Mocks helper
- Create interface for testability HOT 2
- Why I got cors error? HOT 1
- Rate Limiting does not return an error HOT 2
- The template id must be a valid template id for your account issue. HOT 1
- Personalization Subject Override results in (no subject) HOT 5
- Add Email length validation
- Error "The provided authorization grant is invalid, expired, or revoked" when send an email HOT 2
- List-Unsubscribe Header Not Working as Expected HOT 1
- Inbound library does not match sengrid docs or sengrids parsing capability. Serves as a great starter library HOT 5
- Inbound code panics when receiving email from Outlook.com HOT 3
- Bug: inbound.Parse() method panics with text/plain message body HOT 1
- Sending an attachment with a Content-Type including ; (e.g. with character coding specified) causes no "err" and no email... HOT 1
- Getting 500s using Example Code and Status Page Says API is Operational HOT 2
- Support send_each_at mail header HOT 3
- Support Golang 1.18
- Client is not safe for concurrent use
- runtime error index out of range [1] with length 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sendgrid-go.