Comments (2)
To me, the option seems to imply that the whole response should be returned regardless of the response code when the check fails. Currently it looks like this setting only returns the body if the status != 2xx. I don't know if this is an old issue that's still valid or not, so I don't mean to hijack it, but I would like to also have this option include the body not only on when we get a non 2xx response, but also if the expected key is not found, or does not meet one of the conditions specified.
@majormoses Would you be open to a PR that updates how this option works to include the response on other failures as well?
from sensu-plugins-http.
Man that check is a mess, I guess that's what happens when you try to implement curl
and every monitoring use case around it without proper design.
Based on the description of the check option I would assume that it should print the body when status != "ok"
meaning for warning
, critical
, or unknown
statuses which has nothing to do with status codes. The function that generates it should always return the whole body put that does not mean it is printed until the status is evaluated.
I think there are use cases to assert that something intentionally does not exist, that something redirects, etc which would be a non 200 response which leads me to think that this should be a per status configurable setting.
from sensu-plugins-http.
Related Issues (20)
- No output from check-https-cert.rb in Uchiwa HOT 1
- Example in `check-http-json` does not work. HOT 1
- Dependabot can't resolve your Ruby dependency files
- Dependabot can't resolve your Ruby dependency files
- Dependabot can't resolve your Ruby dependency files HOT 1
- metrics-http-json.rb HTTP basic auth HOT 4
- New release with the platform_family fix HOT 1
- check-http.rb --port doesn't work
- check-http.rb fails with IPv6(-only) DNS names
- metrics-http-json.rb: pass custom http headers
- check-https-cert.rb fails with TLS 1.3 only websites HOT 1
- How to incorporate into sensu-agent (check .rb not found) HOT 2
- Error parsing resource: mapping values are not allowed in this context HOT 2
- CheckHttp CRITICAL: Request error: SSL_connect returned=1 errno=0 state=error: sslv3 alert bad record mac
- Checking multiple URIs
- check-http.rb --whole-response always returns full whole output HOT 1
- Problem with new version of OJ when installing the plugins on centos 7
- check-https-cert.rb does not expose "verify_depth" for validating full certificate chain
- CheckHttp CRITICAL: Request error: SSL_connect returned=1 errno=0 state=error: certificate verify failed
- [Security Bug] Insecure crypto usage
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sensu-plugins-http.