Comments (3)
I definitely see the value although I think there should be an option for it but the default should be off.
Reasons why it should default off:
- remaining backwards compatible
- I think that is an excellent way to prompt people to start writing those tips/links/runbooks when they resolve the incident they should think about adding it.
from sensu-plugins-slack.
So would you be thinking of an ignore_field_if_missing: true
flag?
Or perhaps a more structural change to fields themselves, eg
fields:
{
"list": nil,
"clientkeys": "A default value",
"to_render": 123
}
Such that the assigned value is used as a default, and if set to nil
is simply omitted from display if no client value has set it.
Note; I have an extended use case/pull request to develop which will include event field custom values in this listing, such that events themselves can include metadata to submit on alerts
from sensu-plugins-slack.
How about include_missing_fields
with a default of true
. I generally dislike having "negative" variable/option names in code when dealing with booleans. The reason is that it is much clearer and avoids needing to eval true
as false
when I am quickly reviewing code/documentation I am unfamiliar with.
I suppose we could make a more structural change and have a render
flag and if evals nil||true
we would include it. If it evals as false
we would not render.
from sensu-plugins-slack.
Related Issues (20)
- Any chance to port to sensu-go HOT 6
- the plugin ignores HTTP status code
- Can't get working handler HOT 3
- Error SSL, dont work HOT 4
- Problem with "127" (Unknown) exit codes HOT 3
- More then one Slack team does not function properly HOT 1
- Issues with slack multichannel handler HOT 1
- http:// and missing images HOT 5
- icon_emoji attribute not supported by multichannel plugin HOT 2
- slack message_template HOT 3
- Define channel on check. HOT 2
- Add playbook/runbook link to aid operations in resolution of alerts HOT 1
- Event filtering in sensu-plugin is deprecated causing the handler not to always work HOT 14
- Only configured channels recieve notifications? HOT 9
- Update sensu-plugin dep to 2.7 to pick up new Sensu 2 event data mapping HOT 1
- message_template ignored if check has a notification HOT 1
- Slack forces SSL/TLS for all endpoints, even http HOT 1
- Adding payload_template stops messages sending to Slack HOT 2
- Correction in payload_template example in readme
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sensu-plugins-slack.