Giter VIP home page Giter VIP logo

Comments (4)

theofficialgman avatar theofficialgman commented on June 23, 2024

even specifying modrinth does not work.... it still checks curseforge first

mmm -v "1.18.2" install sodium=modrinth
sodium
    🔍 Searching for mod
        1: Failed to connect to https://addons-ecs.forgesvc.net/api/v2/addon/search?gameId=432&sectionId=6&searchFilter=sodium. Retrying in 1.0 seconds...
        2: Failed to connect to https://addons-ecs.forgesvc.net/api/v2/addon/search?gameId=432&sectionId=6&searchFilter=sodium. Retrying in 1.5 seconds...
        3: Failed to connect to https://addons-ecs.forgesvc.net/api/v2/addon/search?gameId=432&sectionId=6&searchFilter=sodium. Retrying in 2.25 seconds...
        4: Failed to connect to https://addons-ecs.forgesvc.net/api/v2/addon/search?gameId=432&sectionId=6&searchFilter=sodium. Retrying in 3.375 seconds...
        5: Failed to connect to https://addons-ecs.forgesvc.net/api/v2/addon/search?gameId=432&sectionId=6&searchFilter=sodium. Retrying in 5.0625 seconds...
        5: Failed to connect to https://addons-ecs.forgesvc.net/api/v2/addon/search?gameId=432&sectionId=6&searchFilter=sodium. Giving up.
        503: Service Unavailable
        🔺 Max retries exceeded. Skipping...
        🔺 1 mods not found
            sodium
                Check so that it's slug is correct. You can set the slug by running:
                minecraft-mod-manager configure sodium=curse:mod-slug,modrinth:mod-slug

please create a 1.4.0 with the commits from master which removed curseforge

from minecraft-mod-manager.

Senth avatar Senth commented on June 23, 2024

Thanks @theofficialgman for letting me know. I've released v1.4.0 which disables the CurseForge API.

The last week, I've been working on a backend that uses the new API since I managed to get an API key. As I can't distribute the key with the app this was the only way I could see how it would work. The backend will also search/get mods from Modrinth.

This will also allow me to improve the search/find functionality without having to add specific slugs in the future 🙂

A bit unsure about the timeline for when Curse is up and running again. Estimate is between 1 and 4 weeks, depending on how much time I can spend on the project 🙂

from minecraft-mod-manager.

theofficialgman avatar theofficialgman commented on June 23, 2024

I am aware of the curseforge issues... seems almost unusable the new api to me. I'm in agreement with peterix's interpretation (from multimc) https://tinyurl.com/28r42fwk (tinyurl so as to not link to that issue)

from minecraft-mod-manager.

Senth avatar Senth commented on June 23, 2024

Yeah, the proxy would also break TOS. But I'm going with that route since if I share the key with the app it won't take long until that key is used in multiple places where I cannot enforce it.

But there is a third solution. The third solution would be to have CurseForge disabled by default and ask each user to apply for a developer API key. The user can then supply the key themselves. But I want to avoid this since it is not user-friendly.

So I'm going with the proxy, and if my key is disabled I will change and add a new header in the API call to the proxy, that way it should still be able to search on CurseForge, even though that would disclose the API key to a third-party (me).

If that's the case I'll try to fix the issue again by moving everything to the client again. 🤷‍♂️

from minecraft-mod-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.