Giter VIP home page Giter VIP logo

Comments (12)

gboudreau avatar gboudreau commented on May 22, 2024 1

@Jason-Morcos I think this was closed by error, when you merged my PR that was reverted..?

from sequel-ace.

gboudreau avatar gboudreau commented on May 22, 2024 1

I can confirm 2.0.2 (I tested using the dev branch really) fixes all the issues with the Assistant; it now correctly prompts to accept new SSH host keys, uses the user-provided password to connect, if any, and prompts for passwords as needed, including the password that might be required to use an encrypted SSH key.

from sequel-ace.

Jason-Morcos avatar Jason-Morcos commented on May 22, 2024

@gboudreau, @jamesstout, @clayreimann
Issue to discuss strict host checking disabled (which was done to allow sandboxing)

from sequel-ace.

Jason-Morcos avatar Jason-Morcos commented on May 22, 2024

@gboudreau Are you certain that strict host checking worked with sandbox off? I've been playing with sandbox off on both the helper and app, fully cleaned, and still not getting prompted to accept a host with strict host checking=yes. I had to specify a new known hosts file of course so it didn't use the old one that already knew my hosts.
I'm getting The SSH Tunnel has unexpectedly closed. every time, which to me suggests there me be something else broken and not just sandbox!

from sequel-ace.

gboudreau avatar gboudreau commented on May 22, 2024

Try using this commit: 141a3f8
I think something else broke after that commit, because I can't seem to make it work using the dev branch either...

from sequel-ace.

Jason-Morcos avatar Jason-Morcos commented on May 22, 2024

You're right. It does work back at that commit. So something else did get broken, probably by me trying to fix it in sandbox world

from sequel-ace.

Jason-Morcos avatar Jason-Morcos commented on May 22, 2024

Was it commit cd4f360 that broke it?

from sequel-ace.

Jason-Morcos avatar Jason-Morcos commented on May 22, 2024

I tried reverted that commit and it still didn't work. Can't seem to figure out what broke it (more)!

from sequel-ace.

Jason-Morcos avatar Jason-Morcos commented on May 22, 2024

Well I figured something big out! Turns out the issue was a build setting CODE_SIGN_INJECT_BASE_ENTITLEMENTS! This is what was causing the helper to crash when sandbox was enabled. https://developer.apple.com/forums/thread/112800

I committed that to dev (3d7ac8a), however whatever broke between 141a3f8 and latest dev means currently the app can't find the helper for some reason

from sequel-ace.

gboudreau avatar gboudreau commented on May 22, 2024

from sequel-ace.

Jason-Morcos avatar Jason-Morcos commented on May 22, 2024

I think I have it fixed for real!! On dev. It didn't like strict host checking being manually set to yes. Checkout dev and let me know, I think we might have this issue fixed!!

from sequel-ace.

Jason-Morcos avatar Jason-Morcos commented on May 22, 2024

Made an RC to make it easier to test! https://github.com/Sequel-Ace/Sequel-Ace/releases/tag/2.0.2-rc1

from sequel-ace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.