Comments (10)
I can take a look, if you are not already on it..?
*edit: No, the problem isn't 437a0bd; I tried reversing only that commit, and the problem is still there. I'll just use git bisect
to find the culprit.
*edit 2: seems to be caused by 0c390d3
from sequel-ace.
@gboudreau I'm not sure what's causing this one. I too had the show details button working a few commits ago. Perhaps sandboxing interrupted this too? Or perhaps it was unrelated
from sequel-ace.
Perhaps it was related to this fix?
from sequel-ace.
Hmmm, sorry fellas. I tested that quite a bit as well...
from sequel-ace.
Some of the return codes used in SPConnectionController
(but not all of them) are defined in SPAlertSheets.m
If we change them in that file, then we'll need to change the returnCodes used in the conditionals everywhere SPAlertSheets
is used.
But I also noticed that sometimes, a regular NSAlert
is used, and return codes needs to use the deprecated values, until those NSAlert
are updated (to use completionHandler:
instead of a didEndSelector:
..?)
from sequel-ace.
Overall, removing all deprecated notices would need some effort in that regard.
I suggest just reverting the modified conditionals, until someone takes more time to resolve the issue globally.
from sequel-ace.
Of note: NSOKButton => NSModalResponseOK
can be kept, as those two are equivalent.
from sequel-ace.
Does this fix it for everyone? I accept both the new and legacy conditional values
from sequel-ace.
Tested ssh fails last night and looked good (not the bind error though, not sure how to replicate). Didn't get chance to check fav import fails or bundle deletes, but for those two I'd changed them to the withCompletion
instantiation. I'll check later.
Just FYI - I'm back to work now and in Hong Kong (GMT+8).
from sequel-ace.
fav import failure just displays one OK button and return code isn't checked.
delete bundle - OK and cancel work as expected.
delete favourite - OK and cancel work as expected.
ssh bad username - buttons work as expected
ssh wrong IP - buttons work as expected
ssh wrong port - buttons work as expected
ssh no key or pass - buttons work as expected
ssh bad key (edit ~/.ssh/id_rsa
) - buttons work as expected
revert edit and re-select key - connection fails. Maybe not copied to .keys
? It is. Needs a bit more testing. Sometimes works sometimes doesn't. But a very rare case for people to be manually editing keys.
cp ~/.ssh/id_rsa.bak
to ~/.ssh/id_rsa
and re-select key - connection works.
from sequel-ace.
Related Issues (20)
- "Save Changes" button is greyed out in connection details HOT 4
- can't connect using ssh HOT 4
- TCP/IP connections fail after upgrading to macOS 14.1.2 HOT 9
- Copy query from "Content" tab with selected filters HOT 2
- Connecting to Teleport DB proxy causes a crash HOT 4
- Content View: After saving value change, view scrolls to far left
- Display open filename while working
- I want to sync preferences on my different macbooks HOT 12
- The table editing doesn't support expression default values HOT 1
- display first line of query/script as window title HOT 1
- Recommendations on UI layout HOT 3
- authentication_oci_client.so HOT 1
- For the same mysql server, Sequel-Pro can connect but Sequel-Ace cannot HOT 4
- Waiting to connect on one tab/window should not lock up the entire application.
- View Structure shows incorrect collations HOT 3
- App freezes when trying to reconnect after host key changes HOT 1
- Can't select ssh key in SSH connection HOT 2
- Right-click Copy and insert on duplicate key update
- Not using SSH Agent when choosing SSH key. Asking for passkey every time. HOT 2
- Freezing on Launch HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sequel-ace.