Giter VIP home page Giter VIP logo

Comments (2)

vicky5124 avatar vicky5124 commented on July 18, 2024

Having Message inside Context would mean that it would have to be in an Option, making it less convenient to use, as FrameworkContext may appear in methods that do not involve commands.
I personally prefer to have them split, it's something i really liked about this library over other's such as d.py
I also don't think it would be cleaner, as it would mean that doing simple stuff such as sending a message would need another item on the tree context.message.channel_id.say() instead of msg.channel_id.say(), or following a previous point context.message.unwrap().channel_id.say() (i do not think msg would be a good field name).
Having the user do let msg = context.message.unwrap() on every single time would just defeat the point of this, and it's better to keep it as it's own function parameter.

from framework.

kangalio avatar kangalio commented on July 18, 2024

That sounds sensible. I'm interested in which circumstances FrameworkContext appears outside of commands?

from framework.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.