Comments (2)
Having Message inside Context would mean that it would have to be in an Option, making it less convenient to use, as FrameworkContext may appear in methods that do not involve commands.
I personally prefer to have them split, it's something i really liked about this library over other's such as d.py
I also don't think it would be cleaner, as it would mean that doing simple stuff such as sending a message would need another item on the tree context.message.channel_id.say()
instead of msg.channel_id.say()
, or following a previous point context.message.unwrap().channel_id.say()
(i do not think msg would be a good field name).
Having the user do let msg = context.message.unwrap()
on every single time would just defeat the point of this, and it's better to keep it as it's own function parameter.
from framework.
That sounds sensible. I'm interested in which circumstances FrameworkContext appears outside of commands?
from framework.
Related Issues (13)
- Implement builtin plain-text and embed help commands
- Implement localisation utilities
- &D as user data instead of Arc<RwLock<D>>?
- Allow serenity model types in argument parsing system HOT 6
- Framework generic parameter deduction fails with type alias HOT 1
- Argument parsing errors should have designated Error enum variant HOT 9
- Roadmap for v0.1.0
- Argument parsing for required and optional arguments should have a flexible order HOT 1
- Add a `OneOf` type for command arguments HOT 2
- Implement `#[check]`
- Implement command arguments
- Port buckets from the original standard framework
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from framework.